improve the sftp push warning

[Steve Alexander]

I was using sftp push, and bzr give me the following worrying warning:

  bzr: WARNING: This transport does not update the working tree of: sftp://whatever/

It took me a while to work out that this means "this is updating only the knit data, not the actual working files". During that time, I was concerned that the push had actually worked.

This should be an "information" message, not a "warning" message, because nothing has gone wrong. There is nothing to worry about. Just something I should be reminded of.

Also, the message should say what it is doing, not just what it is not doing.

Also also, "This transport..." is nonsense. I'm not asking it to use a transport. I'm asking it to push.

So, the message should say something more like this:

  Information: This operation will update only revision history, not working files.

[John Dong (jdong)]

+1

The wording is only understandable by those familiar with RCS jargon... It does need to be more clearly worded. The preface "NOTE" may also sound less threatening than WARNING.

As far as "this transport", it refers to the SFTP transport, versus the FTP or local file transports. My understanding is that specific push behavior can be different between transports, and a future "smart server" may be able to update the working tree efficiently.

[Matthew Paul Thomas (mpt)]

And "" would be even less threatening than "NOTE". :-)

[John A Meinel (jameinel)]

The current bzr.dev code says:
This transport does not update the working tree of: sftp://host/...

And doesn't give any warnings on new style branches that don't have working trees.