checking out a branch from a repo while pulling into the repo causes lock issues

[Marien Zwart]

using bzr 0.8.2 the following steps leave stale locks:

bzr init-repo foorepo

bzr branch /some/random/branch foorepo/branch1
Branched 612 revision(s).

bzr branch /some/other/large/random/branch foorepo/branch2

ctrl+z

bzr checkout --lightweight foorepo/branch1 co1
bzr: ERROR: Could not acquire lock LockDir(/home/marienz/tmp/foorepo/.bzr/repository/lock)
/usr/lib/python2.4/site-packages/bzrlib/lockable_files.py:107: UserWarning: file group LockableFiles(<bzrlib.transport.local.LocalTransport url=/home/marienz/tmp/co1/.bzr/checkout/>) was not explicitly unlocked
  warn("file group %r was not explicitly unlocked" % self)

rm -rf co1

fg
Branched 905 revision(s).

bzr checkout --lightweight foorepo/branch1 co1
bzr: ERROR: Could not acquire lock LockDir(/home/marienz/tmp/foorepo/branch1/.bzr/branch/lock)
/usr/lib/python2.4/site-packages/bzrlib/lockable_files.py:107: UserWarning: file group LockableFiles(<bzrlib.transport.local.LocalTransport url=/home/marienz/tmp/co1/.bzr/checkout/>) was not explicitly unlocked
  warn("file group %r was not explicitly unlocked" % self)

Running break-lock on foorepo/branch1 is needed before it can be used again.

[John A Meinel (jameinel)]

There still is a little bit of a bug, but the code has been cleaned up, so that the lock is now released.

There used to be a bug where if grabbing a lock failed, it would not always clean up all of the other locks. This has been fixed. There is still another bug that a lightweight checkout needs a write lock on its parent. But that is bug 39542