med-xpi-pack breaks INPUT directory

[UNera]

It is a copy of bugreport from debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=551065

If we have easy unpacked (unzipped) xpi which contains jar-file, the
command
 med-xpi-pack unpacked-dir.xpi creating.xpi

will unpack and delete jars in INPUT directory. So input data will be
broken.

[Alexander Sack (asac)]

debian bug is 551065 .... its marked as grave.

[Saša Bodiroža (jazzva)]

On Wed, Oct 21, 2009 at 10:28 AM, Alexander Sack <email address hidden> wrote:
> debian bug is 551065 .... its marked as grave.

I'll submit a fix later this day and ask for your review. The idea I
had in mind is to keep a list of created jars and then to unpack and
remove only them. Sorry for the delay.

--
Best regards,
Saša Bodiroža

[UNera (unera)]

Additional infos:

If there is a package which is built without m-d, which has structure
like an unzipped xpi and added directory debian/, then if we could
rebuild it with m-d, then all jars would be unpacked too.
So we are forced to make repackaging orig.tar.gz.

For exampe package http://packages.qa.debian.org/i/itsalltext.html
has many jars in its build tree.

[Saša Bodiroža (jazzva)]

The proposed fix keeps track of the jar files, which were produced in med-xpi-pack, and at the end unpacks and removes only those jar files. This keeps intact unpacked jar files, which existed before the call of med-xpi-pack.

[UNera (unera)]

We have package which has orig.tgz which has already uploaded into debian/repositaries.
We don't want to make its rebuilding. It would be nice if m-d could disable unpacking jar mode.

[Saša Bodiroža (jazzva)]

I don't think you will need to rebuild a package.

If you unpack a xpi file with med-xpi-unpack, it will also unpack jar files. med-xpi-pack will later pack those unpacked jar files, before adding them to xpi file.

If you already have easy unpacked xpi file, the new med-xpi-pack will add the jar files to xpi file, but won't remove them afterwards, so I think that will fix this bug.

[Saša Bodiroža (jazzva)]

Proposed fix is committed to lp:mozilla-devscripts branch.