Wrong value computation in fields with expressions

[Jordi Esteve (www.zikzakmedia.com)]

If you define emails templates using openerp field expressions with the variable object (like the expression generator does), the corresponding values are not computed and an empty string appears. For example:
${object.address_contact_id.email}
Invoice num. ${object.number}

The problem is in line 77 in poweremail_send_wizard.py: mako render_unicode() method doesn't like a parameter called object. It gives this error: type object 'object' has no attribute 'address_contact_id'

If you change this line

                reply = templ.render_unicode(object=object,peobject=object)

to
                reply = templ.render_unicode(object2=object,peobject=object)

and you define a message with the expression "Invoice num. ${object2.number}" in the email template, it works well.

Now, the temporal solution is to use peobject instead of object inside the expressions in the email template. But the expression generator computes object instead of peobject and it confuses the user.

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

Hi esteve,

the conversion to object was made from peobject in ver 0.6 by the siggestion of mga.
I was not sure if this will have any implications so i retained backward combatibility.

but not sure if ur problem is that.

can u check again. it works for me ...

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

it will help if you can give me ur template

[Jordi Esteve (www.zikzakmedia.com) (jesteve-zikzakmedia)]

Attached there is a screen shot with a template for sending invoices. It works. But if you change peobject to object, all the fields containing ${object.... } (to, cc, subject, body, filename) are empty when the email is computed.

Maybe is the mako version I use (python-mako 0.1.10-1 included in Ubuntu 8.04 LTS: ) that doesn't like a parameter called object.

A solution is replace these calls in poweremail_send_wizard.py: and poweremail_template.py

reply = templ.render_unicode(object=object,peobject=object)
reply = Template(message).render_unicode(object=object,peobject=object)

to

reply = templ.render_unicode(peobject=object)
reply = Template(message).render_unicode(peobject=object)

and before that, change ${object.... } to ${peobject.... }

[Jordi Esteve (www.zikzakmedia.com) (jesteve-zikzakmedia)]

Last line in my last comment:

and before that, change ${object.... } to ${peobject.... }

I would say:

and in a previous line, change the string "${object." to the string "${peobject."

[tst (tst9842)]

Dear all,

i have installed the power email in 5.06 it's ok for installtion,

now if i create the invoice i hve this error " NameError: global name 'Super' is not defined"

i look for the log error t have this text:

File "C:\Documents and Settings\admin\OpenERPAllInOne\Server\addons\poweremail.zip\poweremail\poweremail_serveraction.py", line 64, in run
NameError: global name 'Super' is not defined

thank you

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

tst, moving your bug to a separate bug, since its not the same as above discussion

lp:455410

and i have fixed it too

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

The error with object looks like an error with the mako version.

Mako has to be minimum ver 2

[Jordi Esteve (www.zikzakmedia.com) (jesteve-zikzakmedia)]

Yes, I confirm that I had python-mako 0.1.10 installed (by default in Hardy Haron 8.04.3 LTS)

Now I have update to python-mako 0.2.2.

Thanks.