AgentAddForm link is broken

Bug #452171 reported by Xavier Brochard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Woda
Fix Committed
Low
Xavier Brochard

Bug Description

Perl 5.10
Woda 4.603 (at least) to 4.610

AgentAddForm link in Search results is broken: $formdata contains rights instead of search.

in cgiSearch:
The call to htEscape to generate $formdata use a $x variable already used by wbDenied (wbAllowed) which is called 2 lines upper.

    if ( &wbAllowed( $Group, 'AgentAddForm' ) && !$agentFile ) { => return $x which contains rights

        $text = "I want to subscribe to searches like this."; #UK
        $Formdata = &hashExport(*CGI); => returns $out
        $Formdata = &htEscape($x); => should replace $x by be $Formdata

Please test and confirm this bug, I have a doubt.

------------------

We must check all the variables in Woda. some are globals and can't be change easily, but some others should be limited with local or my. There is a risk of bad side effects with the splitted version.

Xavier Brochard (xavier)
Changed in woda:
importance: Undecided → Low
milestone: none → merge-with-pro
Xavier Brochard (xavier)
Changed in woda:
assignee: nobody → Xavier Brochard (xavier)
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.