AgentAddForm link is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Woda |
Fix Committed
|
Low
|
Xavier Brochard |
Bug Description
Perl 5.10
Woda 4.603 (at least) to 4.610
AgentAddForm link in Search results is broken: $formdata contains rights instead of search.
in cgiSearch:
The call to htEscape to generate $formdata use a $x variable already used by wbDenied (wbAllowed) which is called 2 lines upper.
if ( &wbAllowed( $Group, 'AgentAddForm' ) && !$agentFile ) { => return $x which contains rights
$text = "I want to subscribe to searches like this."; #UK
$Formdata = &hashExport(*CGI); => returns $out
$Formdata = &htEscape($x); => should replace $x by be $Formdata
Please test and confirm this bug, I have a doubt.
------------------
We must check all the variables in Woda. some are globals and can't be change easily, but some others should be limited with local or my. There is a risk of bad side effects with the splitted version.
Changed in woda: | |
importance: | Undecided → Low |
milestone: | none → merge-with-pro |
Changed in woda: | |
assignee: | nobody → Xavier Brochard (xavier) |
status: | New → Fix Committed |