Crash due to brackets

[Simon Schenk]

Binary package hint: tasque

Whenever angle brackets are used in the short or long description of a task, Tasque crashes. This happens bothe when creating a new task and when starting Tasque with such a task on the todo list.
Version used: Ubunut Karmic beta with latest updates.

Here is the output after creating a new note with "<" as title:

[Debug]: Creating a new note
[Debug]: Tasks Modified
Exception in Gtk# callback delegate
  Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception.
System.FormatException: Input string was not in a correct format.
  at System.String.ParseFormatSpecifier (System.String str, System.Int32& ptr, System.Int32& n, System.Int32& width, System.Boolean& left_align, System.String& format) [0x00000]
  at System.String.FormatHelper (System.Text.StringBuilder result, IFormatProvider provider, System.String format, System.Object[] args) [0x00000]
  at System.String.Format (IFormatProvider provider, System.String format, System.Object[] args) [0x00000]
  at System.String.Format (System.String format, System.Object[] args) [0x00000]
  at System.IO.TextWriter.Write (System.String format, System.Object[] arg) [0x00000]
  at System.IO.TextWriter.WriteLine (System.String format, System.Object[] arg) [0x00000]
  at System.IO.SynchronizedWriter.WriteLine (System.String format, System.Object[] value) [0x00000]
  at System.Console.WriteLine (System.String format, System.Object[] arg) [0x00000]
  at Tasque.ConsoleLogger.Log (LogLevel lvl, System.String msg, System.Object[] args) [0x00000]
  at Tasque.FileLogger.Log (LogLevel lvl, System.String msg, System.Object[] args) [0x00000]
  at Tasque.Logger.Log (LogLevel lvl, System.String msg, System.Object[] args) [0x00000]
  at Tasque.Logger.Debug (System.String msg, System.Object[] args) [0x00000]
  at Tasque.Backends.EDS.EDSBackend.TasksModified (System.Object o, Evolution.ObjectsModifiedArgs args) [0x00000]
  at Evolution.CalView.ObjectsModifiedSignalCallback (IntPtr arg0, IntPtr arg1, IntPtr gch) [0x00000]
   at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal)
   at Evolution.CalView.ObjectsModifiedSignalCallback(IntPtr arg0, IntPtr arg1, IntPtr gch)
   at Gtk.Application.gtk_main()
   at Gtk.Application.Run()
   at Gnome.Program.Run()
   at Tasque.GnomeApplication.StartMainLoop()
   at Tasque.Application.StartMainLoop()
   at Tasque.Application.Main(System.String[] args)

** (Tasque:3046): WARNING **: FIXME: wait for completion unimplemented

[Sandy Armstrong (sanfordarmstrong)]

Works fine for me in the latest version from git. I'll have to try 0.1.8 and see if I can reproduce the crash.

What backend are you using?

[Simon Schenk (sschenk)]

Am Freitag, den 16.10.2009, 06:03 +0000 schrieb Sandy Armstrong:
> Works fine for me in the latest version from git. I'll have to try
> 0.1.8 and see if I can reproduce the crash.
>
> What backend are you using?

The backend is Evolution. If I delete the task in Evolution and restart
Tasque, everything is fine again.

Cheers,
Simon

[Sandy Armstrong (sanfordarmstrong)]

I cannot reproduce this in Tasque 0.1.8 built from source on openSUSE 11.2 RC1. I'll have to load up my karmic VM and test in there.

[Sandy Armstrong (sanfordarmstrong)]

Sorry, I can't reproduce this in my Karmic VM either with the standard Tasque package. What kind of hardware are you using?

[Simon Schenk (sschenk)]

I am using a 64bit dual core system.

Cheers,
Simon

Am Samstag, den 17.10.2009, 16:14 +0000 schrieb Sandy Armstrong:
> Sorry, I can't reproduce this in my Karmic VM either with the standard
> Tasque package. What kind of hardware are you using?
>

--
Simon Schenk | ISWeb | Uni Koblenz
http://isweb.uni-koblenz.de
http://www.uni-koblenz.de/~sschenk
Five sentences policy: http://five.sentenc.es/

[Sandy Armstrong (sanfordarmstrong)]

Looking back at your original description, I'm not entirely sure what you are doing to cause the crash. You mention task title and notes, but it would be helpful if you could give the exact steps you are taking to reproduce this bug. Is the task also called "<", or just the note?

Also, please confirm that everything works okay if you follow the same steps but don't use angle brackets.

[Sandy Armstrong (sanfordarmstrong)]

I can reproduce this bug if I take an existing task, and rename it to "}". I can make similar crashes if I use "{" when I rename. But I can't reproduce with "<".

However, if I have a bug named "}", and I create *any* note (named "<" or anything else), the same crash occurs.

This is a problem in latest git as well, and only seems to affect the EDS backend. It will be easy to fix for 0.1.9.

[Sandy Armstrong (sanfordarmstrong)]

Assuming your problem is also really caused by curly braces and not angle brackets, this is now fixed in git. If the Ubuntu packagers want to include this fix, here's the commit:

http://git.gnome.org/cgit/tasque/commit/?id=8eacf29f2a7a4d295d3ccae13272bd1eef2a9dc0

[Simon Schenk (sschenk)]

Thanks, this fixes the bug for me. :)

Am Sonntag, den 18.10.2009, 06:51 +0000 schrieb Sandy Armstrong:
> Assuming your problem is also really caused by curly braces and not
> angle brackets, this is now fixed in git. If the Ubuntu packagers want
> to include this fix, here's the commit:
>
> http://git.gnome.org/cgit/tasque/commit/?id=8eacf29f2a7a4d295d3ccae13272bd1eef2a9dc0
>

--
Simon Schenk | ISWeb | Uni Koblenz
http://isweb.uni-koblenz.de
http://www.uni-koblenz.de/~sschenk
Five sentences policy: http://five.sentenc.es/

[Jack Leigh (leighman)]

Fixed in 0.1.9, as I understand it.
Please reset to 'New' if it's still an issue.