FFE Request: Karmic: Update to latest upstream version 1.52

[Louis Simard]

Binary package hint: laptop-mode-tools

Please update Laptop Mode Tools to the latest version provided by upstream: 1.52.

* Feature Freeze Exception details: Karmic *

Rationale for this FFE: Users of laptops are going to need certain modifications delivered from 1.47, the current version in the main repository, to 1.52, notably these:

Bugs fixed: bugs about wireless device power management (5 fixes), Ethernet speed management (5 fixes), USB (2 fixes), an init script order fix and a hibernation fix. Under the hood, syntax error fixes for the shell scripts.

New features: handling of udevinfo 140's output; adding an option to blacklist broken USB devices from power management; adding support for the Eee PC's FSB control, useful for Ubuntu UNR; finer-grained Laptop Mode Tools debug mode; support for more power management daemons; syslog logging.

Testing done: installed the package, checked that the init script was indeed reordered to 99 (and present), ran /usr/sbin/laptop_mode start and checked that the hard drive spun down after 30 seconds or so, ran /usr/sbin/laptop_mode stop and checked that the hard drive immediately spun up, checked that my mount point "/media/External HDD" was fixed by 1.52. All laptop-mode plugins triggered with no error. No screenshot available, as laptop_mode is a terminal application.

This package is tested and ready, but currently unsigned. I will research into signing the package if this FFE is approved.

Thanks for your time :)

-- init script check (in rc4.d) --
lrwxrwxrwx 1 root root 21 2009-10-03 01:37 S99laptop-mode -> ../init.d/laptop-mode

Attached is the upstream changelog diff from 1.47 excluded to 1.52 included.

[Scott Kitterman (kitterman)]

ack from me for proper integration with udev.

[Louis Simard (louis-simard-deactivatedaccount)]

Whoops...

I'm sorry motu-release, but I saw laptop-mode-tools is in 'main', so it has a larger impact on the release of Karmic, therefore I should have subscribed ubuntu-release instead.

I just saw that there was another section specifically for 'main' in the FreezeException wiki page. You may now unsubscribe yourselves... and I'll subscribe ubuntu-release instead.

Sorry!

[Louis Simard (louis-simard-deactivatedaccount)]

Since Karmic is past BetaFreeze, I'm attaching a debdiff too, for Ubuntu Release to look at.

The Installed-Size being 288 versus the old package's 504 is only because this package has a plethora of small files and my /var partition is using a 1-KiB-block filesystem. Please ignore. The rest of the debdiff is hopefully not so invalid :)

[Steve Langasek (vorlon)]

laptop-mode is not well-integrated with the power management infrastructure in Ubuntu, and should be merged with caution. We definitely do *not* want to sync this package (as the 1.52-1 version number would imply), there are extensive Ubuntu changes to this package relative to Debian that must not be lost and are not candidates for a FFe.

[Ritesh Raj Sarraf (rrs)]

On Friday 09 Oct 2009 06:56:08 Steve Langasek wrote:
> laptop-mode is not well-integrated with the power management
> infrastructure in Ubuntu, and should be merged with caution. We
> definitely do not want to sync this package (as the 1.52-1 version
> number would imply), there are extensive Ubuntu changes to this package
> relative to Debian that must not be lost and are not candidates for a
> FFe.
>

Hi Steve,
So are there any future plans to merge ? Or will Ubuntu keep sticking to 1.47
?

Ritesh
--
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[Louis Simard (louis-simard-deactivatedaccount)]

@ Steve Langasek comment #8:

In my creation of the package, I *have* preserved all the hunks of the 1.47.1-ubuntu2 .diff.gz (taken from karmic main) and edited their line numbers and context by hand to match 1.52 files; I just wasn't aware that the version number for 1.52 had to have ubuntu as well. Should it be ubuntu1 or ubuntu2?

[Tormod Volden (tormodvolden)]

Louis, it should be ubuntu1.

Ritesh, if not before, it will be merged when the merge window for Lucid Lynx opens.

[Louis Simard (louis-simard-deactivatedaccount)]

Rebuilt as 1.51-1ubuntu1, the .diff.gz is now 14540 bytes.

[Tormod Volden (tormodvolden)]

Louis, that is not a debdiff. Run: debdiff old-package.dsc new-package.dsc > old-new-package.debdiff

[Louis Simard (louis-simard-deactivatedaccount)]

Hi Tormod,

Thanks! I had wondered why the output of debdiff was so terse. I had run it against the debs, not the dscs.

Hopefully this is right, now:

debdiff Downloads/laptop-mode-tools_1.47-1ubuntu2.dsc lmt1.52/laptop-mode-tools_1.52-1ubuntu1.dsc > lmt1.52/submission/debdiff-1.47--1.51ubuntu1.txt

Thanks again for your time.

[Tormod Volden (tormodvolden)]

The changelog is incomplete, it should list all remaining Ubuntu changes (explain the difference between 1.52-1 and 1.52-1ubuntu1) and should also be merged with the old Ubuntu changelog so that the whole Ubuntu history is intact. See https://lists.ubuntu.com/archives/ubuntu-x/2009-June/000586.html for a script to do this.

[Louis Simard (louis-simard-deactivatedaccount)]

> The changelog is incomplete, it should list all remaining Ubuntu changes
> (explain the difference between 1.52-1 and 1.52-1ubuntu1)

There has never been a 1.52-1 in any repository. I just wasn't aware that the version number needed -ubuntuNUMBER at the end. The changes between 1.47-1 and 1.47-1ubuntu1 are going to be the exact same changes between "1.52-1" (not a real package!) and 1.52-1ubuntu1, because I only fitted the .diff.gz I took from 1.47-1ubuntu2 in karmic main to match the files in upstream 1.52. I don't see what you're asking me to do here: must I just copy the "Merge with Debian unstable; remaining changes" section from from 1.47-1ubuntu2? And since this isn't a merge with Debian, but a whole new package version, where do I put this?

> and should also be merged with the old Ubuntu changelog so that the
> whole Ubuntu history is intact.

The Ubuntu changelog is intact, since my latest debdiff in this bug is from karmic main's 1.47-1ubuntu2 to this new 1.52-1ubuntu1 (built with the same .diff.gz, as above, with the new changelog lines). The .diff.gz I have for 1.52-1ubuntu1 has 768 lines, with a 70-line or so addition at the top. Again, I don't see what you're asking me to do here.

I know that the -- Uploader Name <email-username@domain> line is wrong; I still don't know who uploads packages, the contributor or the sponsor. Since I've been following both the wiki pages FeatureFreeze and SponsorshipProcess for instructions, conflicting instructions arise: the contributor must have a package ready for upload, but ultimately since I'm not in MOTU or UbuntuDevCore I have to get sponsored for uploads, and the sponsorship process requires only a .diff.gz and a link to upstream source. From the comments in this bug, those pages seem completely illogical.

Since you are asking me to correct the production of my 1.52-1ubuntu1 package as that version, should I take your comment as an implicit ACK with upload by me? should I correct it under the assumption that ubuntu-release only gives ACKs to completed packages, with upload by a sponsor? Should I sign my package, or should the sponsor do that? I'm basically confused and put off from doing much with laptop-mode-tools now. :-/

_________________________________________________________________
Nouveau : connexion à Messenger par MSN
http://go.microsoft.com/?linkid=9677413

[Steve Langasek (vorlon)]

On Sat, Oct 10, 2009 at 12:05:17AM -0000, Louis Simard wrote:
> > The changelog is incomplete, it should list all remaining Ubuntu changes
> > (explain the difference between 1.52-1 and 1.52-1ubuntu1)

> There has never been a 1.52-1 in any repository.

That's not true; Debian unstable has 1.52-1. As we want to be able to
continue merging with Debian in the future, any 1.52-1ubuntu1 upload should
incorporate the Debian 1.52-1 package.

Apparently, merges.ubuntu.com isn't updating currently - probably a bug,
probably gone unnoticed because of where we are currently in the Ubuntu
release cycle.

If you're not going to merge the Debian 1.52-1 package (owing to the
inconvenience of MoM being down, perhaps), then the package should be
numbered 1.52-0ubuntu1 instead.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

[Tormod Volden (tormodvolden)]

> because I only fitted the .diff.gz I took from 1.47-1ubuntu2 in karmic main to match the files in upstream 1.52.

That's sounds good, but you should base it on Debian 1.52-1.

> I don't see what you're asking me to do here: must I just copy the "Merge with Debian unstable; remaining changes" section
> from from 1.47-1ubuntu2?

Yes, that would work, ideally you should check that every bit in the debdiff has a corresponding entry in that list, so we are sure there are no old cruft slipping through or unexpected changes.

>The Ubuntu changelog is intact, since my latest debdiff in this bug is from karmic main's 1.47-1ubuntu2 to this new
> 1.52-1ubuntu1 (built with the same .diff.gz, as above, with the new changelog lines).

You are right, I was thinking wrong.

> I know that the -- Uploader Name <email-username@domain> line is wrong;

Put your own name/address there.

> Should I sign my package, or should the sponsor do that?

The sponsor will apply your debdiff against the old (or Debian) package and sign it and upload.

> I'm basically confused and put off from doing much with laptop-mode-tools now. :-/

It is always difficult the first time. And merging laptop-mode-tools is not the easiest thing. Which is probably why nobody came as far as you with this in Karmic yet :)

Be prepared that this might not be accepted in Karmic because it would bring in too many changes now just before the release, and with not enough time to verify it. Your effort is highly appreciated, and your version can go into Lucid Lynx as soon as it opens for package updates. If Debian releases a newer version meanwhile you should update it accordingly though.

[Louis Simard (louis-simard-deactivatedaccount)]

Hi Tormod and Steve,

Thanks for the words of encouragement. :) However, with the deadline for Karmic final looming, me needing a bit more time to learn about Debian merging (thanks Tormod #15 for the Python script, but I still need to know more), and you guys having to deal with many remaining bugs, I think I'm going to wait until Lucid Lynx is in early alpha to finish up.

[Ritesh Raj Sarraf (rrs)]

Now that Lucid is open for development, I hope we do the merge for laptop-mode-tools.