Launchpad itself

Package translations re-upload should apply filename_filter

Bug #445511 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 3.1.10

Bug Description

When Soyuz uploads translation tarballs from attachTranslationFiles, it passes a filename_filter argument to TranslationImportQueue.addOrUpdateTranslationsFromTarballs. The translations re-upload script should pass the same filename_filter to produce matching (and approvable!) file paths.

On a sidenote, ITranslationImportQueue fails to declare this parameter.

Related branches

lp:~jtv/launchpad/bug-445511
Данило Шеган (community): Approve
Diff: 153 lines
3 files modified
lib/lp/translations/interfaces/translationimportqueue.py (+1/-1)
lib/lp/translations/scripts/reupload_translations.py (+6/-1)
lib/lp/translations/scripts/tests/test_reupload_translations.py (+60/-17)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Fixed in devel 9675

Changed in rosetta:
status: In Progress → Fix Committed
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Fix is in db-devel 8576

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

See also follow-up fix for bug 439346.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Ahem. This *is* the follow-up fix for bug 439346.

Ursula Junque (ursinha)
tags: added: qa-needstesting
Ursula Junque (ursinha)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.