Traceback on trying to edit a task

[Yanko Kaneti]

trying gtg on latest rawhide according to the (Testing and translating time (how to help without programming) blog
just starting the debug script and double clicking a task.
I probably have tomboy data in my home but not tomboy installed. gtg-01 is also installed systemwide

$ bzr branch lp:gtg
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data. See "bzr help launchpad-login".
Branched 339 revision(s).
$ ./scripts/debug.sh
Traceback (most recent call last):
  File "/home/yaneti/cvs/gtg/gtg/GTG/taskbrowser/browser.py", line 1202, in on_edit_active_task
    self.open_task(tid)
  File "/home/yaneti/cvs/gtg/gtg/GTG/taskbrowser/browser.py", line 714, in open_task
    self.get_tasktitle)
  File "/home/yaneti/cvs/gtg/gtg/GTG/taskeditor/editor.py", line 171, in __init__
    self.pengine.onTaskLoad(self.plugins, self.te_plugin_api)
  File "/home/yaneti/cvs/gtg/gtg/GTG/core/plugins/engine.py", line 187, in onTaskLoad
    plugin['instance'].onTaskOpened(plugin_api)
  File "/home/yaneti/cvs/gtg/gtg/GTG/plugins/tomboy/tomboy.py", line 113, in onTaskOpened
    self.addButtonToToolbar(plugin_api)
  File "/home/yaneti/cvs/gtg/gtg/GTG/plugins/tomboy/tomboy.py", line 68, in addButtonToToolbar
    pixbuf_new_from_file_at_size(tb_Taskbutton_image_path, 16, 16)
glib.GError: Failed to open file '/usr/share/icons/hicolor/16x16/apps/tomboy.png': No such file or directory

[Lionel Dricot (ploum-deactivatedaccount)]

Luca, I think this one is for you. (also, I don't think we should activate the plugin by default)

[Luca Invernizzi (invernizzi)]

I absolutely agree, it has to be deactivated by default. I added, on plug-in activation, a check of the presence of tomboy installed. If tomboy is not found, the plug-in notifies the user to either install it or disable the plug-in.

(branch lp:~gtg-user/gtg/tomboy, revision 341

[Lionel Dricot (ploum-deactivatedaccount)]

Luca > it should not be activable at all if tomboy not installed (greyed out, just like the hamster plugin)

[Luca Invernizzi (invernizzi)]

Well, the hamster plugin is greyed out because Paulo's plug-in system checks if the necessary python bindings are available. In this case, they are, so the plugin is not greyed out (in fact, no particular bindings are necessary). I can change that behaviour to accept a "check if you can be activated" function..

[Luca Invernizzi (invernizzi)]

Nevermind. Paulo already thought about that. Revision 342 of lp:~gtg-user/gtg/tomboy solves your issue.
If tomboy is not running, dbus launches it automatically when the plugin is enabled (because we ask dbus if tomboy it's present), but I don't know if that's a bug or not.

[Lionel Dricot (ploum-deactivatedaccount)]

Luca >

Fix Commited should be used only when the fix has been commited to the trunk(and only the trunk)
Fix Released only when the fix is in an actual release

[Lionel Dricot (ploum-deactivatedaccount)]

merged in rev.341