bsdgames ftbfs in karmic

[Bhavani Shankar]

Binary package hint: bsdgames

bsdgames ftbfs in karmic

http://launchpadlibrarian.net/32371264/buildlog_ubuntu-karmic-i386.bsdgames_2.17-16ubuntu1_FAILEDTOBUILD.txt.gz

[Bhavani Shankar (bhavi)]

Attached patch should fix the getline error

[Bhavani Shankar (bhavi)]

PPA Buildlog

http://launchpadlibrarian.net/32748275/buildlog_ubuntu-karmic-i386.bsdgames_2.17-16ubuntu9_FULLYBUILT.txt.gz

http://launchpadlibrarian.net/32748270/buildlog_ubuntu-karmic-amd64.bsdgames_2.17-16ubuntu9_FULLYBUILT.txt.gz

http://launchpadlibrarian.net/32748366/buildlog_ubuntu-karmic-lpia.bsdgames_2.17-16ubuntu9_FULLYBUILT.txt.gz

regards

[StefanPotyra (sistpoty)]

looks good, test-building.

[StefanPotyra (sistpoty)]

hm... still fails to build for me (amd64):

[..]
gcc -g -O2 -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-align -Wcast-qual -Wwrite-strings -Iinclude -Ibattlestar -c battlestar/words.c -o battlestar/words.o
gcc -g -O2 -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-align -Wcast-qual -Wwrite-strings -Iinclude -Ilib -c lib/fgetln.c -o lib/fgetln.o
gcc battlestar/battlestar.o battlestar/command1.o battlestar/command2.o battlestar/command3.o battlestar/command4.o battlestar/command5.o battlestar/command6.o battlestar/command7.o battlestar/cypher.o battlestar/dayfile.o battlestar/dayobjs.o battlestar/fly.o battlestar/getcom.o battlestar/globals.o battlestar/init.o battlestar/misc.o battlestar/nightfile.o battlestar/nightobjs.o battlestar/parse.o battlestar/room.o battlestar/save.o battlestar/words.o lib/fgetln.o -lncurses -o battlestar/battlestar
gcc -g -O2 -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-align -Wcast-qual -Wwrite-strings -Iinclude -Ibcd -c bcd/bcd.c -o bcd/bcd.o
gcc bcd/bcd.o -o bcd/bcd
gcc -g -O2 -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-align -Wcast-qual -Wwrite-strings -DNEW_STYLE -Iinclude -Iboggle/boggle -c boggle/boggle/bog.c -o boggle/boggle/bog.o
In file included from boggle/boggle/bog.c:58:
boggle/boggle/extern.h:46: error: conflicting types for 'getline'
/usr/include/stdio.h:651: note: previous declaration of 'getline' was here
make[1]: *** [boggle/boggle/bog.o] Error 1
make[1]: Leaving directory `/tmp/buildd/bsdgames-2.17'

Looks to me like the patches didn't get applied.

[StefanPotyra (sistpoty)]

erm, maybe you've got a different debdiff, that you would like to have uploaded? (just guessing since the ppa-build log say -16ubuntu9, while the debdiff says -16ubuntu2... maybe something got lost in there?)

[Bhavani Shankar (bhavi)]

strange enough .. I retried builds on my PPA and then converted whole thing into a patch

will look into

Regards

[Fabrice Coutadeur (fabricesp)]

Hi,

As there is nothing to sponsor at the moment, I'll unsubscribe u-u-s.
Please resubscribe Ubuntu Universe Sponsors when ready.

Thanks,
Fabrice

[Bhavani Shankar (bhavi)]

This attached patch applies

bhavani@foolhardy:~/bsdgames1/bsdgames-2.17$ quilt push -a
Applying patch getline-error.patch
patching file gomoku/bdisp.c
patching file gomoku/main.c
patching file gomoku/gomoku.h
patching file cribbage/crib.c
patching file cribbage/io.c
patching file cribbage/cribbage.h
patching file boggle/boggle/extern.h
patching file boggle/boggle/mach.c
patching file boggle/boggle/bog.c

Applying patch add-acronyms.patch
patching file wtf/acronyms
patching file wtf/acronyms.comp

Applying patch quiz-presidents.patch
patching file quiz/datfiles/pres

Now at patch quiz-presidents.patch

Regards

[StefanPotyra (sistpoty)]

Nope, that still doesn't build for me, since debian/rules is broken (build-stamp calls dh build but does not pass --with quilt).

Even doing that, it doesn't yet build for me, as the patches don't apply cleanly.

@RainCT: what have you done with bsdgames? :P

I'd personally suggest to just drop quilt and apply the patches inline. RainCT: Do you object?

[Siegfried Gevatter (rainct)]

No, I don't care, it's all yours Stefan!

FYI, my initial intentional was to move everything over to quilt and do a QA upload to Debian, but after having dpkg-source destroy half of my work I got tired of it (well, mostly, because of the perspective of having to look for a DD ;)) and just uploaded the new stuff to Ubuntu so that it doesn't get lost. The package builds fine on Debian, by the way, seems like gcc gets more evil every release :P.

[Bhavani Shankar (bhavi)]

Yes thats the thing I was trying to convey.. The patch applies manually but not on buildd sadly because of rules file.. I ll try simplepatchsys then..

Will get back shortly

Regards

[Bhavani Shankar (bhavi)]

uh oh it doesnt use cdbs style packaging .. sorry for that assumption

here is the diff with changes directly applied inline

[Bhavani Shankar (bhavi)]

I modified the quiz-presidents.patch while applying direct inline as the patch as it is does not apply cleanly

bhavani@foolhardy:~/bsdgames/bsdgames-2.17$ quilt push -a
Applying patch add-acronyms.patch
patching file wtf/acronyms
patching file wtf/acronyms.comp

Applying patch quiz-presidents.patch
patching file quiz/datfiles/pres
patching file gomoku/gomoku.6
Hunk #1 FAILED at 45.
1 out of 1 hunk FAILED -- rejects in file gomoku/gomoku.6
patching file arithmetic/arithmetic.6
Hunk #1 FAILED at 79.
1 out of 1 hunk FAILED -- rejects in file arithmetic/arithmetic.6
patching file backgammon/teachgammon/ttext2.c
Hunk #1 FAILED at 65.
1 out of 1 hunk FAILED -- rejects in file backgammon/teachgammon/ttext2.c
patching file backgammon/teachgammon/ttext1.c
Hunk #1 FAILED at 94.
1 out of 1 hunk FAILED -- rejects in file backgammon/teachgammon/ttext1.c
Patch quiz-presidents.patch does not apply (enforce with -f)

So I took out remaining part as I found its already fixed in respective files

Regards

[StefanPotyra (sistpoty)]

Patch looks good. Your changelog is a bit misleading (both that quilt is broken :P and that the changes are remaining changes... quilt wasn't part of the unstable package). However that's nothing that holds me from uploading it now ;).

Thanks for your work!