"Define upstream link" form text is gibberish
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Curtis Hovey |
Bug Description
1. Go to the page for a distribution source package that is not currently linked to an upstream project.
2. Choose "Set upstream link".
What happens:
* You arrive at a page with the heading "Define upstream link".
* The form label says "Product Series".
* The caption says "The best guess we have as to the Launchpad ProductSeries [sic] for this Source Package [sic]. Try find [sic] packaging information for this specific distroseries [sic] then try parent series and previous Ubuntu series."
* The button says "Change".
What should happen:
* If the page heading and the link to the page both use verbs, they should be the same verb unless there's a really good reason for them to differ. "Define" is not an appropriate verb for this task. A better heading would be "Link to an upstream project".
* The form should not refer to things that don't exist in Launchpad, such as "product series".
* The form label should use standard Launchpad capitalization and punctuation, i.e. "Project series:" rather than "Product Series".
* The language should be free from grammar errors.
* If possible, the button should not suggest you are changing something that didn't exist beforehand.
Related branches
- Brad Crittenden (community): Approve (code)
-
Diff: 182 lines4 files modifiedlib/lp/bugs/stories/distribution/xx-distribution-upstream-bug-report.txt (+2/-1)
lib/lp/registry/browser/sourcepackage.py (+36/-2)
lib/lp/registry/browser/tests/sourcepackage-views.txt (+49/-4)
lib/lp/registry/interfaces/sourcepackage.py (+4/-5)
affects: | soyuz → launchpad-registry |
Changed in launchpad-registry: | |
status: | New → Triaged |
importance: | Undecided → Low |
milestone: | none → 3.1.10 |
tags: | added: package-link |
Changed in launchpad-registry: | |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
Fixed in launchpad devel r9789.