ProductBranchVocabulary token should be branch.unique_name

[David Allouche]

Currently the token used by the ProductBranchVocabulary (that ends up displayed in the form) is the branch.id.

We must not expose database branch ids in the UI. Instead we should use the guaranteed-unique and more human-readable Branch.unique_name for that purpose.

[David Allouche (ddaa)]

See https://launchpad.net/products/bzr/+bug/40474/+addbranch for an example.

Initially reported as bug 42488.

[James Henstridge (jamesh)]

My jamesh/launchpad/branch-vocabulary branch fixes this up, and also lets people enter a registered branch URL as a token too.

[David Allouche (ddaa)]

Does it also allow using the public supermirror url for a branch?

If yes, then it does all that was originally intended.

[James Henstridge (jamesh)]

The code for parsing a string token to a vocabulary term does this:

 1. check if the token looks like an http, https, ftp or sftp URL
 2. if so, then use IBranchSet.getByUrl() to find the branch.
 3. otherwise use IBranchSet.getByUniqueName().

The getByUrl() method checks for both the registered URL and our mirror URL, so the vocabulary handles both (there is a test to verify this).

[James Henstridge (jamesh)]

Fixed in today's production rollout.