German file save uses reserved word "Tag"

Bug #437852 reported by daniel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Phatch
Fix Released
Medium
Stani
phatch (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

It is not possible to use the 4th option in rename/filename dropdown dialog.
The german word for day is Tag, wich is already used as a variable in phatch.
Suggestion: use dayOfWeek, that is "WochenTag"

tested OK Fix:
#: /home/stani/sync/python/phatch/trunk/phatch/actions/time_shift.py:43
msgid "day"
msgstr "WochenTag"

It would be nice to see two digits for every number in order to comply with ISO format & readability
(NOT working here)
formField.py
160: DATE = '<%02s>-<%02s>-<%02s>'%(_t('year'), _t('month'), _t('day'))

Tags: localisation
Stani (stani)
Changed in phatch:
milestone: none → 0.2.2
assignee: nobody → stani (stani)
importance: Undecided → Medium
Revision history for this message
Stani (stani) wrote :

The problem is not the translation of the word 'day', but of the word 'Tag'. Therefore I used for 'Tag' the same translation as already given for 'tag': Stichwort

I fixed this in rosetta: https://translations.launchpad.net/phatch/trunk/+pots/phatch/de

This is fixed in bzr trunk.

Changed in phatch:
status: New → Fix Committed
Revision history for this message
Stani (stani) wrote :

BTW the formatting you wanted is: <Jahr>-<##Monat>-<##Tag>-<##Stunde>-<##Minute>-<##Sekunde>

This will be the default for future phatch versions. Please do not discuss this further here but on the phatch forums:
http://photobatch.wikidot.com/forum:start

I reopen the bug as i see another related error popped up.

Changed in phatch:
status: Fix Committed → In Progress
Stani (stani)
summary: - german file save uses reserved word "Tag"
+ German file save uses reserved word "Tag"
Revision history for this message
Stani (stani) wrote :

Fix committed in trunk

=== modified file 'phatch/lib/pyWx/popup.py'
--- phatch/lib/pyWx/popup.py 2009-09-22 17:10:51 +0000
+++ phatch/lib/pyWx/popup.py 2009-10-01 03:18:24 +0000
@@ -166,7 +166,7 @@
             v = parent.SplitValue(value)[0]
         else:
             v = value
- v = self._to_local(v).strip()
+ v = v.strip()
         if v and v not in local_choices:
             local_choices.insert(0, v)
         super(TextCtrl, self).__init__(parent, id, value,
@@ -699,7 +699,7 @@
         #create ctrl instance
         if Ctrl._busy_cursor:
             wx.BeginBusyCursor()
- self.edit = Ctrl(self, value=value_as_string,
+ self.edit = Ctrl(self, value=Ctrl._to_english(value_as_string),
                             size=(height, height-2*border), **extra)
         #check min size
         if self.edit.GetSize()[1] > height:

Changed in phatch:
status: In Progress → Fix Committed
Stani (stani)
Changed in phatch:
status: Fix Committed → Fix Released
Stani (stani)
Changed in phatch (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package phatch - 0.2.3-2

---------------
phatch (0.2.3-2) unstable; urgency=low

  * phatch.desktop and menu files are now shipped by phatch package
    (LP: #449210)
    - add lintian overrides for above changes (phatch depends on phatch-cli so
      everything is ok)

phatch (0.2.3-1) unstable; urgency=low

  * Upstream bugfix release (Closes LP: #448845, #446725, #445943)

phatch (0.2.2-1) unstable; urgency=low

  * Upstream bugfix release (Closes LP: #236548, #436595, #437161,
   #437376, #437852, #439108, #439359, #440273, #440956)
  * debian/control: Dropped dependency python-wxgtk2.6

 -- Julien Lavergne <email address hidden> Tue, 13 Oct 2009 18:49:27 +0100

Changed in phatch (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.