Pressing about twice doesn't show aboutdialog correctly

[Ivan]

If you press about button twice, or more, shows an aboutdialog deformed, a 1x1 window.

glnew.py:59: GtkWarning: gdk_x11_atom_to_xatom_for_display: assertion `atom != GDK_NONE' failed
  aboutdialog.run()
glnew.py:59: GtkWarning: gtk_widget_show: assertion `GTK_IS_WIDGET (widget)' failed
  aboutdialog.run()
glnew.py:59: GtkWarning: gtk_widget_hide: assertion `GTK_IS_WIDGET (widget)' failed
  aboutdialog.run()
glnew.py:59: GtkWarning: gtk_label_set_text: assertion `GTK_IS_LABEL (label)' failed
  aboutdialog.run()
glnew.py:59: GtkWarning: gtk_container_foreach: assertion `GTK_IS_CONTAINER (container)' failed
  aboutdialog.run()

Revision: http://bazaar.launchpad.net/~olifanteam/olifant/latest-dev/revision/14

[Ahmed El-Mahdawy (propeng)]

I think destroy() is destroying every control in the window, and must be initialized again.
A possible fix is to move the initialization code (everything between # About Dialog and # tray icon) to show_about, so it looks like this:

def show_about(widget, data=None):
 aboutdialog = gtk.AboutDialog()
 aboutdialog.set_name('Olifant')
 ...
 aboutdialog.set_logo(gtk.gdk.pixbuf_new_from_file('pixmaps/icon.png'))
 aboutdialog.run()
 aboutdialog.destroy()

[Ivan (inovembri-deactivatedaccount)]

yes, I made something similar and I moved the creation of the about window to utils.

I'm going to upload changes in the latest-dev.

[Ivan (inovembri-deactivatedaccount)]

Solved in latest-dev rev 15.
http://bazaar.launchpad.net/~olifanteam/olifant/latest-dev/revision/15