Approver logs spurious conflicts
Bug #435699 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Jeroen T. Vermeulen | ||
Bug Description
When an import queue entry matches multiple templates based on path and origin, the approver now logs a warning instead of crashing.
But it logs too many conflicts. Take this one for example:
Found 3 templates with path 'po/apt-all.pot' for package apt (0 matched on from_sourcepack
Yes, there are 3 templates with that path for that package. But they're for 3 different distroseries!
The mistake is in POTemplateSet.
A consequence of this will be that uploads for these templates won't be auto-approved, which would be a problem for the Ubuntu folks.
Related branches
lp:~jtv/launchpad/bug-435699
- Brad Crittenden (community): Approve (release-critical)
- Michael Nelson (community): Approve (code)
-
Diff: 82 lines2 files modifiedlib/lp/translations/model/potemplate.py (+4/-0)
lib/lp/translations/tests/test_autoapproval.py (+32/-8)
| description: | updated |
| Changed in rosetta: | |
| milestone: | 3.0 → 3.1.10 |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-devel 8515