mailman needs more extensive sys.path hacking
Bug #435604 reported by
Barry Warsaw
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Barry Warsaw |
Bug Description
At the top of Mailman's mm_cfg.py file, we have this bit of sys.path hackery:
# Set up Mailman's sys.path to pick up the top of Launchpad's tree
import sys
sys.path.insert(0, '/home/
this is no longer enough though, because e.g. zope.i18nmessageid is no longer in lib, it's an egg. So it fails with an import error in mm_cfg.py trying to import canonical.
We need to extend the sys.path hacking here to ensure that all the eggs are on sys.path as well. Probably importing _pythonpath will do it.
Related branches
lp:~barry/launchpad/435604-mailman
Merged
into
lp:launchpad
- Brad Crittenden (community): Approve (release-critical)
- Paul Hummer (community): Approve
-
Diff: 824 lines17 files modifiedlib/canonical/launchpad/mailman/monkeypatches/__init__.py (+35/-80)
lib/canonical/launchpad/mailman/monkeypatches/mm_cfg.py.in (+65/-0)
lib/lp/services/mailman/doc/basic-integration.txt (+89/-0)
lib/lp/services/mailman/doc/bounces.txt (+1/-0)
lib/lp/services/mailman/doc/contact-address.txt (+2/-2)
lib/lp/services/mailman/doc/create-lists.txt (+2/-2)
lib/lp/services/mailman/doc/decorations.txt (+1/-2)
lib/lp/services/mailman/doc/logging.txt (+27/-24)
lib/lp/services/mailman/doc/messages.txt (+3/-1)
lib/lp/services/mailman/doc/modify-lists.txt (+5/-3)
lib/lp/services/mailman/doc/postings.txt (+17/-16)
lib/lp/services/mailman/doc/reactivate-lists.txt (+4/-2)
lib/lp/services/mailman/doc/recovery.txt (+9/-5)
lib/lp/services/mailman/doc/staging.txt (+2/-3)
lib/lp/services/mailman/doc/subscriptions.txt (+11/-7)
lib/lp/services/mailman/testing/helpers.py (+1/-1)
lib/lp/services/mailman/testing/logwatcher.py (+2/-2)
Changed in launchpad-registry: | |
importance: | High → Critical |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Don't forget though that mm_cfg.py is autogenerated from the template in lib/canonical/ launchpad/ mailman/ monkeypatches/ __init_ _.py so the hack must be added there.