Fade will sporadically break if I set "hold_time" to anything other than 0.

Bug #435595 reported by Tom Rothamel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ren'Py
Fix Released
Medium
Tom Rothamel

Bug Description

I'm going to attempt to keep this as short as possible so please pardon my terseness. But I feel some thanks are in order regardless: thank you for creating such a great program. :)

I had an old version of Ren'Py (6.6.3) and decided to update to 6.9.3. I then noticed that Fade will sporadically break if I set "hold_time" to anything other than 0. When it breaks it never draws the new scene that's supposed to show after the fade. (I have to interrupt the transition with a right-click or holding ctrl.) The annoying thing is that sometimes it DOES work, but I haven't been able to nail down why.

After going through past versions I THINK I've nailed down my problem to the transition.py file that comes immediately after 6.9.1h. The one that fixes, "A regression that causes a massive slowdown of the Dissolve and ImageDissolve transitions."

http://www.renpy.org/wiki/renpy/releases/6.9.1

Fade appears to work as expected in version 6.9.1h, however, if I overwrite the transition.py in my 6.9.1h install with the aforementioned one, Fade starts working erratically for me. I'm going to compare the two .py files and tinker around a bit, but I thought I'd send off this e-mail first.

---

Reproducing the error:

Basically I just created a new project and then changed the line in "options.rpy" dealing with the end game transition to this:

    config.end_game_transition = Fade(1, 1, 1, color="#0F0")

I tried it on three different computers. On one computer (Windows XP SP3), it always gets stuck on a green screen till I right-click. On the other two (another Windows XP SP3 and the other Vista) it'll work every so often, which leaves me baffled.

-Rob

Revision history for this message
Tom Rothamel (renpytom) wrote :

I'm not 100% sure what's causing this. The only big difference I can think of is that with hold_time, we're dissolving to a Solid. I've altered the way Solid creates images, and hopefully that will fix the problem.

Changed in renpy:
status: New → Fix Committed
Revision history for this message
Tom Rothamel (renpytom) wrote :

(Hit send too quick.)

I was unable to replicate the bug on my system, so I am kinda flying blind here. Please test 6.10.0 when it comes out.

Tom Rothamel (renpytom)
Changed in renpy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.