new lines in the changes file Binary: field triggers a parsing error

Bug #435316 reported by Sebastien Bacher
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jelmer Vernooij

Bug Description

Trying to sync http://packages.qa.debian.org/m/mono/news/20090907T224401Z.html failed on "2009-09-23 14:20:52 ERROR Exception while processing upload /home/lp_queue/sync-queue/incoming/seb128-20090923-152046 (OOPS-1362U2)", the issue is due to the new line chars in the .changes Binary list, dropping those made the flush-sync works as expected

Related branches

Celso Providelo (cprov)
summary: - new lines chars in the Binary list triggers parsing issue
+ new lines in the changes file Binary: field triggers a parsing error
tags: added: soyuz-upload
Changed in soyuz:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Celso Providelo (cprov) wrote :

Related with bug #436182

Changed in soyuz:
milestone: none → 3.1.10
Revision history for this message
Michael Nelson (michael.nelson) wrote :

This should be fixed in devel r9708 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9708>.

I can't find the above oops to verify whether this bug was caused by the corrupt data in our database producing invalid index files (in which case the work-around is already CP'd in production) or whether it's the result of the initial parsing error (in which case the fix is in r9708 which will be rolled out with LP 3.1.10).

I've chatted with Sebastien and he'll let us know if it re-occurs :)

Changed in soyuz:
assignee: nobody → Michael Nelson (michael.nelson)
status: Triaged → Fix Committed
Changed in soyuz:
status: Fix Committed → Fix Released
Revision history for this message
Julian Edwards (julian-edwards) wrote :
Changed in soyuz:
milestone: 3.1.10 → none
status: Fix Released → Triaged
Jelmer Vernooij (jelmer)
Changed in launchpad:
status: Triaged → In Progress
assignee: Michael Nelson (michael.nelson) → Jelmer Vernooij (jelmer)
tags: added: bugjam2010
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This is not so much due to the fact that ChangesFile doesn't accept newlines but more because gina generates/generated invalid changes files.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This was actually fixed by my changes to use python-debian for gina earlier this year. I'll add some tests to demonstrate this.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Jelmer Vernooij (jelmer)
tags: added: qa-untestablee
removed: qa-needstesting
tags: added: qa-untestable
removed: qa-untestablee
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.