Sale Order: Change in pricelist should affect order lines

[forstera]

Hello,
When we duplicate a sale order, the values on the bottom of the form (Untaxed Amount, Taxes, Total) looked like to be freezed.
I can add new lines, remove all lines to my sale order and click the button 'Compute', no value changes.

In the same way, but all the time (not only duplicate sale orders) if I change my price list of my sale order and click the 'Compute' button, my prices dont change. I need to re-introduce my articles to affect the new pricelist.

[Numérigraphe (numerigraphe)]

forstera a écrit :
> Public bug reported:
>
> Hello,
> When we duplicate a sale order, the values on the bottom of the form (Untaxed Amount, Taxes, Total) looked like to be freezed.
> I can add new lines, remove all lines to my sale order and click the button 'Compute', no value changes.
>
FYI I couldn't reproduce this behavior with yesterday's v5.0-bzr.
> In the same way, but all the time (not only duplicate sale orders) if I
> change my price list of my sale order and click the 'Compute' button, my
> prices dont change. I need to re-introduce my articles to affect the
> new pricelist.
As far as I can tell, this is the "expected" behavior - I mean it's
designed to do just that.
Lionel.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Arnaud,

Are you sure you are using the latest versions of server and addons codes?

This is neither 'producible' nor 'expected' here.

Those functional fields should get updated when SO Line(s) change(s)(without regard to its a new SO or duplicated). And they are updated normally.

I would like to request you to check again.

Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Ideally,

One should select a pricelist first and then add order lines.
Agreeing to your point, Let us try to sort out this issue.

Thank you for the report.

[forstera (arnaud-forster-deactivatedaccount)]

Hello Jay,

I'm just upgrading right now. But the problem is that my table (which
contains data) cannot be upgrated ... it seems to be the source of the
problem.

2009-09-24 08:07:16,262] WARNING:orm:column 'amount_tax' in table
'sale_order' has changed type (DB = float8, def = float) but unable to
migrate this change !
[2009-09-24 08:07:16,287] WARNING:orm:column 'amount_untaxed' in table
'sale_order' has changed type (DB = float8, def = float) but unable to
migrate this change !
[2009-09-24 08:07:16,290] WARNING:orm:column 'amount_total' in table
'sale_order' has changed type (DB = float8, def = float) but unable to
migrate this change !
[2009-09-24 08:07:16,346] WARNING:orm:column 'amount_untaxed' in table
'purchase_order' has changed type (DB = float8, def = float) but unable
to migrate this change !
[2009-09-24 08:07:16,359] WARNING:orm:column 'amount_tax' in table
'purchase_order' has changed type (DB = float8, def = float) but unable
to migrate this change !
[2009-09-24 08:07:16,381] WARNING:orm:column 'amount_total' in table
'purchase_order' has changed type (DB = float8, def = float) but unable
to migrate this change !
[2009-09-24 08:07:16,442] WARNING:orm:column 'amount_untaxed' in table
'account_invoice' has changed type (DB = float8, def = float) but unable
to migrate this change !
[2009-09-24 08:07:16,450] WARNING:orm:column 'amount_tax' in table
'account_invoice' has changed type (DB = float8, def = float) but unable
to migrate this change !
[2009-09-24 08:07:16,472] WARNING:orm:column 'residual' in table
'account_invoice' has changed type (DB = float8, def = float) but unable
to migrate this change !
[2009-09-24 08:07:16,489] WARNING:orm:column 'amount_total' in table
'account_invoice' has changed type (DB = float8, def = float) but unable
to migrate this change !

[2009-09-24 08:07:17,891] WARNING:orm:column 'amount_tax' in table
'sale_order' has changed type (DB = float8, def = float) but unable to
migrate this change !
[2009-09-24 08:07:17,916] WARNING:orm:column 'amount_untaxed' in table
'sale_order' has changed type (DB = float8, def = float) but unable to
migrate this change !
[2009-09-24 08:07:17,919] WARNING:orm:column 'amount_total' in table
'sale_order' has changed type (DB = float8, def = float) but unable to
migrate this change !

Meilleures salutations.

____________________________
MW Programmation SA
Arnaud Forster
IT Manager

Rue Charles Schäublin 2 | CH-2735 Malleray | Suisse
phone:[phone] | fax:[phone]
email: <email address hidden> | web: www.mwprogrammation.ch

Jay (Open ERP) a écrit :
> Hello Arnaud,
>
> Are you sure you are using the latest versions of server and addons
> codes?
>
> This is neither 'producible' nor 'expected' here.
>
> Those functional fields should get updated when SO Line(s)
> change(s)(without regard to its a new SO or duplicated). And they are
> updated normally.
>
> I would like to request you to check again.
>
> Thanks.
>
>

[forstera (arnaud-forster-deactivatedaccount)]

Hello Jay,

I just upgraded to the last version and this solved the problem. I
tested the patch concerning the warnings during the update (
https://bugs.launchpad.net/openobject-server/+bug/433886

and this seems to work, too.

.. so, the last thing is the problem of the change of the pricelist

Thanks for your efforts

Regards

Meilleures salutations.

____________________________
MW Programmation SA
Arnaud Forster
IT Manager

Rue Charles Schäublin 2 | CH-2735 Malleray | Suisse
phone:[phone] | fax:[phone]
email: <email address hidden> | web: www.mwprogrammation.ch

Jay (Open ERP) a écrit :
> Hello Arnaud,
>
> Are you sure you are using the latest versions of server and addons
> codes?
>
> This is neither 'producible' nor 'expected' here.
>
> Those functional fields should get updated when SO Line(s)
> change(s)(without regard to its a new SO or duplicated). And they are
> updated normally.
>
> I would like to request you to check again.
>
> Thanks.
>
>

[Jay Vora (Serpent Consulting Services) (jayvora)]

Yes, Arnaud.

Thank you for the response.

We are taking care of the same.

Thanks.

[invitu (invitu)]

Dear all,

I would ask that instead of having onchange() property, the computation of new prices when pricelist changes would be associated with a separate "Compute listprice" button.

It would allow to have a better control for prices calculation.

The following scenario would work :
- We change the pricelist and do a recalculation of prices for each line in the order
- We could change partner without reassign new prices and by clicking on the "Compute" button, only the tax would be calculated without changing the prices in the order.

Moreover, the same improvement would be very useful in purchase module too.

Regards

[Dhruti Shastri(OpenERP) (dhs-openerp)]

Hello Arnaud and Invitu,

I am attaching the Sale extend Module which will add wizard "Change Pricelist". This wizard will change the priecelist of sale order as you specified.

Please note that It is compatible with Trunk.

Have a check with the module and let us know.

Thanks

[Kinly (kinlyfordy4u)]

hi...

Is there any need for new module for price list ?
can we use that code in existing sale module ?

[Dhruti Shastri(OpenERP) (dhs-openerp)]

Hello Kinly,

This is a new feature and we cannot add this in the module of a stable release.

So, here is a new module made compatible with trunk. You may use the same code for your stable module if needed so.

Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

This was an added development, it may land into extra-addons.
Thanks.