Edit icon for merge proposals status should be inline

Bug #435197 reported by Martin Albisetti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Paul Hummer

Bug Description

In the conversion to 3.0, the link to change the status of a merge proposal has been moved into the global actions menu. This is not a global action, and should be restored to be besides the actual status.
The rule for 3.0 is that anything that is displayed and can be edited, should have the edit icon next to it.

Related branches

Jonathan Lange (jml)
tags: added: post-3-ui-cleanup
Paul Hummer (rockstar)
Changed in launchpad-code:
status: Triaged → In Progress
assignee: nobody → Paul Hummer (rockstar)
milestone: none → 3.1.10
Revision history for this message
Paul Hummer (rockstar) wrote :

I'm happy to do this work, but I guess I'm confused about what a "global action" is then. My understanding was that because it operated on the branch merge proposal itself, it was a "global action" Martin, could you please explain?

Revision history for this message
Martin Albisetti (beuno) wrote :

The global actions menu was re-introduced for actions that are global to the page, that cannot be represented inline well, and in some exceptional cases, to highlight the main action for a page.
In this case, the status is already shown in the page, so the edit icon should be next to it.
Anything that can be represented and edited, we should offer to edit it from there.

Revision history for this message
Paul Hummer (rockstar) wrote :

Fixed in rev 9681

Changed in launchpad-code:
status: In Progress → Fix Committed
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.