Breadcrumbs display for IHasMajorHeading views
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Undecided
|
Michael Nelson |
Bug Description
According the the current heading rules at:
https:/
for pages where the context is the root context, breadcrumbs should not display.
The url:
https:/
is a bit strange, in that the sprint content class does provide IRootContext, and so the heading is displayed in the watermark. Adding IMajorHeadingView to the SprintView then correctly ensures that the heading is displayed as an H1 - but the breadcrumbs still display below the application tabs. (Note, we don't normally see this, for example, for people, because there are not normally > 1 breadcrumbs, but in this case there is one for the ISprintSet and then the index.)
Barry provided a work-around for this, which was to provide a SprintIndexHier
Another work-around would be to disable/remove the ISprintSet breadcrumb - I'm not sure what would be better. I'll take a look at what would be involved to fix the actual bug too.
Related branches
- Brad Crittenden (community): Approve (release-critical)
- Barry Warsaw (community): Approve (code ui*)
- Diff: None lines
description: | updated |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
Here's a patch - I'll get salgado to take a look, and if it's ok, land it with my branch.