test failures trying to escape isolation

Bug #433843 reported by Vincent Ladeuil
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Low
Vincent Ladeuil
0.14
Fix Released
Low
Gary van der Merwe

Bug Description

bzr.dev now checks that the test don't try to make file access outside of their test directory.

bzr selftest -s bp.qbzr
testing: /home/vila/src/bzr/trunk/bzr
   /home/vila/src/bzr/trunk/bzrlib
   bzr-2.1.0dev python-2.6.2 Linux-2.6.28-15-generic-x86_64-with-Ubuntu-9.04-jaunty

ERROR: bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch
    Attempt to escape test isolation: 'file:///non_existant_branch/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch/', 'file:///tmp/testbzr-QEKq5i.tmp/']

ERROR: bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode
    Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode/']

ERROR: bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode
    Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode/']

ERROR: bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode
    Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode/']

ERROR: bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode
    Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode/']

======================================================================
ERROR: test_open_locations_raise_not_a_branch (bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider)

vvvv[log from bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch]
0.952 creating repository in file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch/work/repo/.bzr/.
0.960 opening working tree '/tmp/testbzr-QEKq5i.tmp'

^^^^[log from bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vila/.bazaar/plugins/qbzr/lib/tests/test_loggraphprovider.py", line 158, in test_open_locations_raise_not_a_branch
    gp.open_locations, ["/non_existant_branch"])
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1220, in assertRaises
    callableObj(*args, **kwargs)
  File "/home/vila/.bazaar/plugins/qbzr/lib/loggraphprovider.py", line 296, in open_locations
    BzrDir.open_containing_tree_branch_or_repository(location)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 990, in open_containing_tree_branch_or_repository
    bzrdir, relpath = klass.open_containing(location)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 899, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 920, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 855, in open_from_transport
    hook(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 999, in _preopen_isolate_transport
    self._preopen_isolate_url(url)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1014, in _preopen_isolate_url
    % (url, self._bzr_selftest_roots))
BzrError: Attempt to escape test isolation: 'file:///non_existant_branch/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_loggraphprovider.TestLogGraphProvider.test_open_locations_raise_not_a_branch/', 'file:///tmp/testbzr-QEKq5i.tmp/']

======================================================================
ERROR: test_errors_no_ui_mode (bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch)

vvvv[log from bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode]
1.100 opening working tree '/tmp/testbzr-QEKq5i.tmp'

^^^^[log from bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vila/.bazaar/plugins/qbzr/lib/tests/test_tree_branch.py", line 38, in test_errors_no_ui_mode
    ui_mode=False, _critical_dialog=mf)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1220, in assertRaises
    callableObj(*args, **kwargs)
  File "/home/vila/.bazaar/plugins/qbzr/lib/tree_branch.py", line 71, in open_containing
    ) = bzrdir.BzrDir.open_containing_tree_or_branch(location)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 972, in open_containing_tree_or_branch
    bzrdir, relpath = klass.open_containing(location)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 899, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 920, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 855, in open_from_transport
    hook(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 999, in _preopen_isolate_transport
    self._preopen_isolate_url(url)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1014, in _preopen_isolate_url
    % (url, self._bzr_selftest_roots))
BzrError: Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_no_ui_mode/']

======================================================================
ERROR: test_errors_ui_mode (bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch)

vvvv[log from bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode]
1.104 opening working tree '/tmp/testbzr-QEKq5i.tmp'

^^^^[log from bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vila/.bazaar/plugins/qbzr/lib/tests/test_tree_branch.py", line 50, in test_errors_ui_mode
    ui_mode=True, _critical_dialog=mf)
  File "/home/vila/.bazaar/plugins/qbzr/lib/tree_branch.py", line 71, in open_containing
    ) = bzrdir.BzrDir.open_containing_tree_or_branch(location)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 972, in open_containing_tree_or_branch
    bzrdir, relpath = klass.open_containing(location)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 899, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 920, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 855, in open_from_transport
    hook(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 999, in _preopen_isolate_transport
    self._preopen_isolate_url(url)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1014, in _preopen_isolate_url
    % (url, self._bzr_selftest_roots))
BzrError: Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_tree_branch.TestTreeBranch.test_errors_ui_mode/']

======================================================================
ERROR: test_no_ui_mode (bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree)

vvvv[log from bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode]
1.301 opening working tree '/tmp/testbzr-QEKq5i.tmp'

^^^^[log from bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vila/.bazaar/plugins/qbzr/lib/tests/test_util.py", line 178, in test_no_ui_mode
    util.open_tree, '/non/existent/path', ui_mode=False, _critical_dialog=mf)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1220, in assertRaises
    callableObj(*args, **kwargs)
  File "/home/vila/.bazaar/plugins/qbzr/lib/util.py", line 1060, in open_tree
    return WorkingTree.open_containing(directory)[0]
  File "/home/vila/src/bzr/trunk/bzrlib/workingtree.py", line 344, in open_containing
    control, relpath = bzrdir.BzrDir.open_containing(path)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 899, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 920, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 855, in open_from_transport
    hook(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 999, in _preopen_isolate_transport
    self._preopen_isolate_url(url)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1014, in _preopen_isolate_url
    % (url, self._bzr_selftest_roots))
BzrError: Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_no_ui_mode/']

======================================================================
ERROR: test_ui_mode (bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree)

vvvv[log from bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode]
1.305 opening working tree '/tmp/testbzr-QEKq5i.tmp'

^^^^[log from bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vila/.bazaar/plugins/qbzr/lib/tests/test_util.py", line 193, in test_ui_mode
    tree = util.open_tree('/non/existent/path', ui_mode=True, _critical_dialog=mf)
  File "/home/vila/.bazaar/plugins/qbzr/lib/util.py", line 1060, in open_tree
    return WorkingTree.open_containing(directory)[0]
  File "/home/vila/src/bzr/trunk/bzrlib/workingtree.py", line 344, in open_containing
    control, relpath = bzrdir.BzrDir.open_containing(path)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 899, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 920, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/home/vila/src/bzr/trunk/bzrlib/bzrdir.py", line 855, in open_from_transport
    hook(transport)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 999, in _preopen_isolate_transport
    self._preopen_isolate_url(url)
  File "/home/vila/src/bzr/trunk/bzrlib/tests/__init__.py", line 1014, in _preopen_isolate_url
    % (url, self._bzr_selftest_roots))
BzrError: Attempt to escape test isolation: 'file:///non/existent/path/' [u'/tmp/testbzr-QEKq5i.tmp/', 'file:///tmp/testbzr-QEKq5i.tmp/', u'/tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode/', 'file:///tmp/testbzr-QEKq5i.tmp/bzrlib.plugins.qbzr.lib.tests.test_util.TestOpenTree.test_ui_mode/']

----------------------------------------------------------------------
Ran 82 tests in 1.095s

FAILED (errors=5)
Missing feature '_PyEnchantFeature' skipped 7 tests.
vila:~/src/PLUGINS/qbzr/trunk :( $

Related branches

Vincent Ladeuil (vila)
Changed in qbzr:
status: New → Confirmed
assignee: nobody → Vincent Ladeuil (vila)
status: Confirmed → In Progress
Vincent Ladeuil (vila)
Changed in qbzr:
status: In Progress → Fix Committed
Changed in qbzr:
importance: Undecided → Low
Changed in qbzr:
milestone: none → 0.15
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.