Tearing down Windmill sometimes breaks with a ValueError("invalid thread id")

[Björn Tillenius]

Sometimes when tearing down Windmill using teardown(shell_objects), a ValueError is raised:

Traceback (most recent call last):
  File "/devel/launchpad/bug-430813/lib/lp/testing/__init__.py", line 339, in run
    testMethod()
  File "/devel/launchpad/bug-430813/lib/lp/bugs/windmill/tests/test_bug_commenting.py", line 35, in test_bug_commenting
    teardown(shell_objects)
  File "/devel/launchpad/rocketfuel/eggs/windmill-1.3beta2-py2.4.egg/windmill/bin/admin_lib.py", line 222, in teardown
    shell_objects['httpd'].stop()
  File "/devel/launchpad/rocketfuel/eggs/windmill-1.3beta2-py2.4.egg/windmill/server/https.py", line 427, in stop
    t.terminate()
  File "/devel/launchpad/rocketfuel/eggs/windmill-1.3beta2-py2.4.egg/windmill/server/thread2.py", line 46, in terminate
    self.raise_exc(SystemExit)
  File "/devel/launchpad/rocketfuel/eggs/windmill-1.3beta2-py2.4.egg/windmill/server/thread2.py", line 41, in raise_exc
    _async_raise(self._get_my_tid(), exctype)
  File "/devel/launchpad/rocketfuel/eggs/windmill-1.3beta2-py2.4.egg/windmill/server/thread2.py", line 13, in _async_raise
    raise ValueError("invalid thread id")
ValueError: invalid thread id

[Björn Tillenius (bjornt)]

I have submitted a fix upstream for review.

[Diogo Matsubara (matsubara)]

Fixed in devel r9597 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9597>