Import from branch imports hidden files
Bug #430736 reported by
Jeroen T. Vermeulen
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Henning Eggers |
Bug Description
For BaShare we have a file BaShare/.lang/.pot on the import queue. A file whose
name starts with a dot should be ignored; it's more likely to be an editor
backup file or somesuch.
See TranslationImpo
picks out "usable" translation files from a series of file paths. Perhaps the
two can be unified.
Related branches
lp:~henninge/launchpad/bug-430736-hidden-files
Merged
into
lp:launchpad
- Aaron Bentley (community): Approve
-
Diff: 230 lines (+82/-34)6 files modifiedlib/lp/code/model/branchjob.py (+2/-0)
lib/lp/code/model/tests/test_branchjob.py (+37/-6)
lib/lp/translations/interfaces/translationimporter.py (+8/-0)
lib/lp/translations/model/translationimportqueue.py (+3/-27)
lib/lp/translations/utilities/tests/test_translation_importer.py (+25/-0)
lib/lp/translations/utilities/translation_import.py (+7/-1)
Changed in rosetta: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: code-integration |
Changed in rosetta: | |
status: | Triaged → In Progress |
assignee: | nobody → Henning Eggers (henninge) |
milestone: | none → 10.02 |
tags: |
added: qa-ok removed: qa-needstesting |
To post a comment you must log in.
I am not reusing the code from TranslationImpo rtQueue. addOrUpdateEntr iesFromTarball because that only checks for hidden *files* but I also want to exclude files in hidden *directories*, like po/.hidden/foo.pot.