LaunchpadObjectFactory.makeImportBranch has no real use

Bug #429813 reported by Paul Hummer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Paul Hummer

Bug Description

I used LaunchpaObjectFactory.makeImportBranch in make harness to create a few import branches while reworking the branch index page. After working the templates a bit, I found that the pages look odd if the branch has no code_import property (and in the new redesign's case, outright oopses). After talking with Michael and sleuthing code, I'm pretty confident that this is a case that should NEVER happen in production.

LaunchpadObjectFactory.makeCodeImport creates a branch with the code import. It's probably the preferred implementation, and uses the same methods as are used in production to create code imports and import branches. makeImportBranch should go away.

Tags: lp-code

Related branches

Paul Hummer (rockstar)
Changed in launchpad-code:
milestone: none → 10.01
status: Triaged → In Progress
Revision history for this message
Paul Hummer (rockstar) wrote :

Fixed in devel rev 10183

Changed in launchpad-code:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.