bin/test --layer=MailmanLayer no longer works
Bug #429375 reported by
Barry Warsaw
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Undecided
|
Björn Tillenius |
Bug Description
It used to be that "bin/test --layer=
Related branches
lp:~bjornt/launchpad/bug-429375
Merged
into
lp:launchpad
- Brad Crittenden (community): Approve (code)
- Diff: None lines
tags: | added: story-windmill-layer |
Changed in launchpad-foundations: | |
milestone: | none → 3.0 |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
--layer isn't being ignored. The issue is that bin/test specifies some default options, that you can't remove. One of those options is "--layer= !MailmanLayer" . This means that if you run "bin/test --layer= MailmanLayer" , it's like running "bin/test --layer= !MailmanLayer --layer= Mailmanlayer" , which means: run all layer that aren't MailmanLayer, as well as those layers that are MailmanLayer.
There are a few different options for fixing this. My favourite so far is to only add those default options if it isn't specifed in the command line. I.e., if you pass in --layer=foo, don't add the default --layer option. If you pass in -s or --package, don't add the default --package options.