Impossible to edit bug descriptions with Konqueror

Bug #427263 reported by Julian Edwards
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LAZR Javascript Library
Triaged
High
Unassigned
Launchpad itself
Triaged
Medium
Unassigned

Bug Description

When browsing bugs with Konqueror (4.3 for me) the edit icon on the description widget is not there, meaning it's impossible to edit the description even with the non-js fallback boomerang form.

This problem also affects the new PPA page which is landing shortly.

It may save time to fix this bug at the same time as bug 394189, bug 397457, and/or bug 393825.

Tags: lp-bugs

Related branches

Revision history for this message
Julian Edwards (julian-edwards) wrote :
Revision history for this message
Eleanor Berger (intellectronica) wrote :

On Konqueror 4.2.2 I don't even get the tab graphic.

Changed in malone:
status: New → Triaged
importance: Undecided → High
milestone: none → 3.0
affects: malone → lazr-js
Changed in lazr-js:
milestone: 3.0 → none
description: updated
summary: - Impossible to edit bug descriptions with Konqeror
+ Impossible to edit bug descriptions with Konqueror
description: updated
Changed in lazr-js:
assignee: nobody → Michael Nelson (michael.nelson)
Revision history for this message
Michael Nelson (michael.nelson) wrote :

So the issue seems to be that Konqueror doesn't display an element (in this case <a></a>) if it has no content - and so the styles that we add (such as the background image) are not displayed either.

Adding some content (such as &nbsp; or 'Edit') shows the edit icon as expected in Konq4.3 but we don't want that text (or an underlined space) for the other supported browsers. Also, it doesn't make sense for the inline editor widget to remove the text as other callsites might want to have text in the trigger link.

Another option we tried (thanks to Bjorn) was to leave 'Edit' in the anchor so it's non-empty, but then use a style rule to set the content to "". This allowed Konqueror to display the icon on it's own, but FF and Chromium still display the 'Edit' text (actually, FF and Chromium seem to ignore the content style rule - not sure why).

Changed in lazr-js:
assignee: Michael Nelson (michael.nelson) → nobody
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

The fix is easy: insert a zero-width joiner. With that change I can do basic multi-line editing in Konqueror 4.3.2. But that doesn't fix the problems with older Konqueror versions; see bug 331584. Even with Konqueror 4.3.2 there are lots of test failures.

Changed in lazr-js:
status: Triaged → In Progress
assignee: nobody → Jeroen T. Vermeulen (jtv)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

No wait, better idea: it turns out we can trick Konqueror into rendering the button by applying some pointless :link/:visited CSS to the link. An empty content attribute does the trick.

It should be harmless. There's no text to replace, but moreover, AFAICS that attribute should be ignored for the :link and :visited pseudoclasses anyway.

Changed in launchpad:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Jeroen T. Vermeulen (jtv)
status: In Progress → Fix Committed
affects: launchpad → malone
Changed in lazr-js:
status: In Progress → Fix Committed
Ursula Junque (ursinha)
Changed in malone:
milestone: none → 10.01
tags: added: qa-needstesting
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Argh. The CSS fix got Konqueror to render the edit icons in general, but the one in the bug title is misplaced somewhere. When I resize the window to be only just wide enough to accommodate the bug title, the edit icon suddenly shows up right below it.

Changed in lazr-js:
status: Fix Committed → Fix Released
Changed in malone:
status: Fix Released → In Progress
milestone: 10.01 → 10.02
Changed in lazr-js:
status: Fix Released → In Progress
tags: added: qa-bad
removed: qa-needstesting
Changed in malone:
milestone: 10.02 → 10.03
Changed in malone:
assignee: Jeroen T. Vermeulen (jtv) → nobody
milestone: 10.03 → none
Changed in lazr-js:
assignee: Jeroen T. Vermeulen (jtv) → nobody
Deryck Hodge (deryck)
Changed in malone:
status: In Progress → Triaged
Changed in lazr-js:
status: In Progress → Triaged
Deryck Hodge (deryck)
tags: removed: qa-bad
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.