Podcast plugin unable to parse a feed that has non-enclosure entries

[ben.mckenzie]

Version of Exaile: current development source
OS: Gentoo Linux

Behavior: A podcast feed has entries that do not have an mp3 associated with them. An example of such a feed is here:

http://feeds2.feedburner.com/AllGamesConsidered

(Note: The feed cannot be parsed unless the SVN version of feedparser is used in the plugin, per bug#426775.)

Error produced:

Traceback (most recent call last):
  File "/home/benm/Projects/Exaile/exaile/data/plugins/podcasts/__init__.py", line 168, in _parse_podcast
    tr.set_loc(e['enclosures'][0].href)
IndexError: list index out of range

Because there's no enclosure on a non-media feed, the podcast plugin returns an empty list that errors out when reading the podcast.

Expected behavior: The feed should at least load all available media episodes and not error out.

Quick, non-good hack:

A try/except message can get past the non-media feeds, allowing Exaile to ignore the portions that have no media. I'm unsure how to check for a list that has no entries in it, because it's not showing up as 'None'. Attached is a quick hack, which will skip over the feed if it is unable to read a media file.

[ben.mckenzie (ben-k-mckenzie)]

The patch here should get everything working on podcast feeds that have null-media entries.

[ben.mckenzie (ben-k-mckenzie)]

Sorry for all the posting. I actually found a better way of patching it up using an "if" statement rather than a "try/except" statement, and wanted to get it posted for anybody that needed it.

[Steve Dodier-Lazaro (sidi)]

Thanks for your report and patches, Ben. The person managing the podcast
plugin is quite busy at the moment, so it might take time before you get
feedback on this bug, but be sure that your effort is appreciated.

[ben.mckenzie (ben-k-mckenzie)]

That's fine. I noticed you all were busy, and I was worried someone might do the try/except patch on their own, which could cause bigger problems.

Keep up the good work!

[Jason Miller (aidenn0)]

Ben: Will your patch work in the case where e is not empty, but contains no enclosures? I had fixed this independently locally with the attached patch

[Dustin Spicuzza (dustin-virtualroadside)]

Sorry about the delay, not sure why this was never fixed. Committed to trunk in r4449.