'bzr rm' should do wildcard expansion on Windows
Bug #426410 reported by
Martitza
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
John A Meinel |
Bug Description
See similar Bug 425510.
Using bzr 1.18...
C:>mkdir t
C:>cd t
C:\t>bzr init
Created a standalone tree (format: pack-0.92)
C:\t>echo > cat.txt
C:\t>echo > bat.txt
C:\t>bzr add
adding bat.txt
adding cat.txt
C:\t>bzr commit -m "import" Committing to: C:/t/ added bat.txt added cat.txt Committed revision 1.
C:\t>bzr rm *.txt
bzr: ERROR: [Error 123] The filename, directory name, or volume label syntax is incorrect: u'C:/t/*.txt\\*.*'
~M
Related branches
lp:~jameinel/bzr/2.1.0b3-win32-shell-completion
- David Roberts (community): Needs Information
- Alexander Belchenko: Needs Fixing
- Martin Packman (community): Abstain
- Robert Collins (community): Approve
-
Diff: 410 lines5 files modifiedNEWS (+9/-0)
bzrlib/builtins.py (+0/-1)
bzrlib/commands.py (+6/-5)
bzrlib/tests/test_win32utils.py (+92/-2)
bzrlib/win32utils.py (+152/-27)
Changed in bzr: | |
status: | New → Confirmed |
importance: | Undecided → High |
tags: | added: easy |
Changed in bzr: | |
assignee: | nobody → John A Meinel (jameinel) |
milestone: | none → 2.1.0b3 |
status: | Confirmed → Fix Committed |
Changed in bzr: | |
status: | Fix Committed → Won't Fix |
status: | Won't Fix → Fix Released |
To post a comment you must log in.
I'm not sure but shouldn't wildcard expansion be handled at shell basis. As far as I remember the windows shell did expand wildcards the last time I used windows.
Activating wildcard expansion within bazaar would conflict with filenames containing * as filename character in quoted arguments. At least on unix.
touch "file_0" "file_1" "file_*"
bzr add
bzr ci -m "added files: file_*, file_1, file_0"
bzr rm "file_*"
only "file_*" should be removed not "file_0" and "file_1". I'm not quiet sure how windows handles expansion nowadays.