Add a setting in the covers preferences dialog to disable automatic fetching

[Steve Dodier-Lazaro]

At the moment, users can remove covers but these will be fetched again automatically.

The proposed behaviour is that a setting is added in the preferences dialog (covers section, which is quite empty right now). This setting would be named "Fetch album cover on playback start" and could have the following values :

Always
If not manually removed before
Never

Also, since the automatic cover fetcher would have to respect this implementation, the user-removed covers there could have a different icon (such as a gtk-remove like grey icon), and when displayed in the main GUI, the nocover icon could be used. Users would have to explicitely click on "Fetch cover" in the menu to have the covers back (of course this would immediately reset the "dont fetch covers" flag in the db).

Such an implementation could be seen as a bugfix for the fact that the covers are re-fetched after being removed and thus land in 0.3.0.x.

[Steve Dodier-Lazaro (sidi)]

Part 1 implemented as a bugfix in order to enable users to actually remove covers in Exaile 0.3.0.x

WARNING: due to problems with my branch, I could NOT check this patch. I can not guarantee it'll work or even run so please check it out before anything.

[Steve Dodier-Lazaro (sidi)]

I'm tired, sorry.

[reacocard (reacocard)]

Patch has multiple issues - no settings import, prefs checkbox is unchecked by default and doesn't appear to actually set anything on the backend, etc. Please redo it and actually test it this time.

[Steve Dodier-Lazaro (sidi)]

All my apologizes for that. I'm uploading a new patch, tested the setting, and it works here. The cover will get shown only if it was already in the trackdb for that track, when automatic fetching is disabled.

[reacocard (reacocard)]

logic has been put into 0.3.0.x, we can't add the gui part as that would break string freeze.

logic only has also been put into trunk since this patch is pre-gtkbuilder, so the gui side of it does not apply cleanly.

[Ubuntuxer (johannes-schw)]

I updated your patch and fixed a small bug, so it runs on the current branch.

[Ubuntuxer (johannes-schw)]

Upps, I forgot to upload patch.

[reacocard (reacocard)]

fixed trunk/2729