cover are not removed from cover management window if removed

[zebul666]

if i remove a cover with the right-click menu 'Remove cover', it is still shown in the cover management window.

this is not a really good thing.
you need to close the cover window and reopen it to see that the cover is gone.

moreover (might be another bug)
even if i remove the old cover (the small one from last.fm) and fetched a big one from amazon with the amzon plugin, and validate.
then the cover shown by double-clicking the thumbnail is still the old one (the small) and not the big ... sight

[Steve Dodier-Lazaro (sidi)]

Remind me to run some tests and fix that tonight ^.^

[zebul666 (zebul666)]

the right one is when i double-click on thumbnail in gui next to track info
the left one is from cover manager

[zebul666 (zebul666)]

it seems even with big cover from amazon, the cover manager continues to show the cover at 80x80 i.e. like the thumbnail even when you have double-click on the thumbnail or used 'Show cover'.

whereas they are shown at the correct size when double-clicking on thumbnail cover in gui next to track detail above playlist.

[zebul666 (zebul666)]

here is a fix for the cover displayed at the wrong size.
the bug was that it was the thumbnail that was displayed instead of the image cover

[zebul666 (zebul666)]

ah and add this

        if c == None:
            return

--- xlgui/cover.py 2009-09-07 01:45:01.000000000 +0200
+++ xlgui/cover.py 2009-09-07 19:15:11.000000000 +0200
@@ -119,7 +119,12 @@
         """
             Shows the currently selected cover
         """
- cover = self.covers[self.get_selected_cover()]
+ item = self._get_selected_item()
+ c = self.manager.coverdb.get_cover(item[0], item[1])
+ if c == None:
+ return
+ cover = gtk.gdk.pixbuf_new_from_file(c)
         window = CoverWindow(self.parent, cover)
         window.show_all()

but there will be no gui when thiere is no cover. might not wanted

[zebul666 (zebul666)]

so here is another patch that almost fix it.
when you remove the cover, the thumbnail really change to 'nocover' image this time. but guess what !

when you reopen exaile, and reopen the cover manager the cover is back again !
although it has been deleted from the coverdb.
so it seems cover is not saved to disk ! timestamp of cover.db show it has not been modified
so it's another bug ... OMG

[Steve Dodier-Lazaro (sidi)]

Thanks for the patches.