flickr: last 7 interesting days menu doesn't display

[Philippe Normand]

1. Goto Internet > Pictures > Flickr
2. Try to enter: "Last 7 interesting days"

Traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 630, in gotResult
    _deferGenerator(g, deferred)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 607, in _deferGenerator
    deferred.callback(result)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 243, in callback
    self._startRunCallbacks(result)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 312, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 328, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "/home/phil/bzr/moovida/elisa-plugins/elisa/plugins/flickr/resource_provider.py", line 306, in response_read
    photo_model.server = int(photo.attributes['server'].nodeValue)
exceptions.ValueError: invalid literal for int() with base 10: ''

[Philippe Normand (philn)]

Oh well this morning on the demo set I couldn't reproduce this bug. Might be nice to add a try/except or something to avoid this traceback, anyway.

[Olivier Tilloy (osomon)]

For sure, but my take is that this happens only when flickr return an incomplete XML, which we can safely assume won't happen too often. Lowering the importance.

[Olivier Tilloy (osomon)]

This bug is happening again this morning.
I'm attaching the response we get from Flickr for easier investigation.
For information, this response contains an "empty" photo (an XML node with all attributes that are empty strings), line 50:

  <photo id="" owner="" secret="" server="" farm="0" title="" ispublic="" isfriend="" isfamily="" />

This is the one that makes the whole parsing fail.

[Olivier Tilloy (osomon)]

I wrote a trivial patch that ignores "empty" photos. It's on its way to the review.

[laura burbaite (lburbaite)]

verified, tested in moovida release V1.8.0

[Olivier Tilloy (osomon)]

FYI: the bug is not fixed in moovida _1.0.8_.
It just happens that today Flickr returns a well-formed XML response, as it usually does.

[Olivier Tilloy (osomon)]

The issue can be observed again today with Moovida 1.0.8. It is fixed in the development branch and the fix will be released with 1.0.9.

[laura burbaite (lburbaite)]

Flickr-> Last 7 days interesting is functioning fine.
Tested in Windows 7.