PO import queue hits a problem with product and distroseries count

[Данило Шеган]

We are using shortlist with no parameters to fetch all product and distro series in translation import queue.

This fails with:

 /srv/launchpad.net/production/launchpad-rev-8334/lib/lp/translations/model/translationimportqueue.py:1060: UserWarning: shortlist() should not be used here. It's meant to listify sequences with no more than 15 items. There were 17 items.
  distinct=True))

We have a few products with more than 15 series, and some are close. We should obviously fix this to not be broken in this way.

I will be investigating some more and seeing if this is a critical problem or not.

[Jeroen T. Vermeulen (jtv)]

It's not the number of productseries that's breaking this shortlist, but the number of distinct products that have Approved entries in the queue.

What I don't get is why this isn't breaking the UI as well: see TranslationImportTargetVocabularyFactory. That uses getRequestTargets too, and as far as I can see, in ways that should return even more products.

[Jeroen T. Vermeulen (jtv)]

Ah, it's not actually breaking; it's logging warnings. Though that may still affect things somehow.

[Jeroen T. Vermeulen (jtv)]

Fixed in devel 9352