bzr upgrade should remove backup.bzr after a successful upgrade
Bug #422450 reported by
Trond Norbye
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Low
|
Matthew Fuller | ||
Bug Description
After running bzr upgrade it leaves backup.bzr in the repository even after a successful upgrade (it can be left in there upon failures if there is some info in there that might be useful for sending back to the bzr developers to help track down a bug). There shouldn't be any reason bzr to add new files visible for the user to the tree after running bzr upgrade.
Why? well you will most likely have a backup of your repository from _before_ doing the upgrade you will be using if you want to revert to the old format (and the backup.bzr will probably not help you much if you want to downgrade after adding a lot of new commits to your repository anyway). Leaving the directory there will only confuse the (newbie) users (like myself).
Related branches
lp:~fullermd/bzr/smooth-upgrades
- Vincent Ladeuil: Approve
- Martin Pool: Needs Fixing
-
Diff: 531 lines (+395/-25)7 files modifiedbzrlib/builtins.py (+50/-15)
bzrlib/bzrdir.py (+34/-0)
bzrlib/tests/blackbox/test_upgrade.py (+23/-0)
bzrlib/tests/test_upgrade.py (+86/-1)
bzrlib/upgrade.py (+192/-9)
doc/en/release-notes/bzr-2.3.txt (+5/-0)
doc/en/whats-new/whats-new-in-2.3.txt (+5/-0)
Revision history for this message
| Martin Pool (mbp) wrote | #1 |
| Changed in bzr: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| tags: | added: upgrade |
| Changed in bzr: | |
| assignee: | nobody → Matthew Fuller (fullermd) |
| status: | Confirmed → In Progress |
| Changed in bzr: | |
| milestone: | none → 2.3b5 |
| status: | In Progress → Fix Released |
To post a comment you must log in.
I'm not sure we should specifically delete it, but we should certainly handle the backup more gracefully.