Making a private team the owner of a project fails if the project has a ProductRelease

Bug #422128 reported by Brad Crittenden
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Brad Crittenden

Bug Description

Doing QA for bug 410416 I got an OOPS trying to set the owner to a private team. The project has a ProductRelease and that causes the failure as seen in OOPS-1339S192.

Tags: lp-registry

Related branches

Brad Crittenden (bac)
affects: launchpad → launchpad-registry
Changed in launchpad-registry:
milestone: none → 3.0
Revision history for this message
Brad Crittenden (bac) wrote :

The reason for this failure is that in the view code for products changing the owner calls _reassignProductDependencies which changes the owner of the product translation import queues, product series, and product releases. The way this change is done is problematic for a number of reasons:

1) The reassignment happens in the browser code so changes via other mechanisms, such as the web service or direct manipulation in a test, have different affect than doing it through the web.

2) There is no reason to change the owner of a product series or product release. In fact, that data element is shown in the UI as 'registrant', which has historical implications. It is unclear whether changing the import queue 'importer' is necessary or desired.

So the view method _reassignProductDependencies should either go away (if not required for translation import queue) or be moved to the model as part of a setter for product.owner.

Either way, the owner of product releases and product series should not be changed, which will solve this bug since a team will never be used as the owner of those objects.

Changed in launchpad-registry:
importance: High → Low
Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: Brad Crittenden (bac) → nobody
milestone: 3.0 → none
Brad Crittenden (bac)
Changed in launchpad-registry:
status: Triaged → In Progress
assignee: nobody → Brad Crittenden (bac)
importance: Low → High
milestone: none → 3.1.10
Revision history for this message
Brad Crittenden (bac) wrote :

r 9639

Changed in launchpad-registry:
status: In Progress → Fix Committed
Brad Crittenden (bac)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.