some files in etc have DOS line endings

[Martijn Faassen]

Some files in the etc directory created by Grokproject have DOS line endings (\r\n). In particular these files are site.zcml.in, zdaemon.conf.in and zope.conf.in.

This is not a disaster but our convention is to use Unix line endings. The grok project template needs to be adjusted to use Unix line endings (\n).

[Uli Fouquet (uli-gnufix)]

I noticed that too, but as we want to create correct config files on Windows as well, I was wondering whether using '\n' could break projects generated on Windows (but didn't check really). AFAICS DOS endings do no harm to Unix projects, so it was okay for me to have the templates with DOS endings.

[Reinout van Rees (reinout)]

In r103034, one week ago, I ran an eol-fixer script I nicked from Guido Wesdorp over several of the grok svn projects, amongst them grokproject. This set the eol-style to native (as should have been set all the time, people just forget to stick to zope's svn rules...) and fixes existing line endings.

An svn checkout (and subsequent grokproject run) on windows should still be OK.

Can someone check with grokproject trunk whether it is OK now?

(I also set some svn:ignores for bin/, parts/, .installed.cfg here and there, btw).

[Martijn Faassen (faassen)]

Yeah, there shouldn't be a problem with \n endings on Windows - we consistently want to use that everywhere.

Anyway, sounds like grokproject is therefore already fixed in SVN - thanks Reinout! Can you check, Uli?

[Michael Haubenwallner (d2m)]

just did an update on my trunk checkout and cannot see the ^M characters in vi anymore.

reinout fixed the line endings recently

SVN: grok/trunk/ line endings fixes
Log message for revision 103035:
  line endings fixes

SVN: grokproject/trunk/ Fixed line endings
Log message for revision 103034:
  Fixed line endings

[Uli Fouquet (uli-gnufix)]

Checked on WinXP: everything seems to work smoothly :-)

Fortunately also all other changes to grokproject seem to run successful on windows (did a full install including new Python, etc. Only the missing grok.View permission not available with Grok 1.0a4 was a stopper, but this is a different topic).

Thanks to everybody! That was quick :-)