SubprocessUIFactory & QUIFactory lack several important methods

Bug #421851 reported by Alexander Belchenko
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Gary van der Merwe

Bug Description

SubprocessUIFactory has only get_password methods, but there is many other user-interaction methods which we should support otherwise some commands seems to hang. E.g. see https://bugs.launchpad.net/bugs/418252, new qrun command hang on interactive commands like break-lock which are used get_boolean IMO.

So, looking at bzr.dev/bzrlib/ui/text.py I see there is following methods we are lacking:

get_boolean(self, prompt)
get_non_echoed_password(self) ???
get_username

non_echoed password used by get_password which we re-implement. But it's possible some code uses it directly (bzr-svn?).

Tags: qsubprocess

Related branches

Changed in qbzr:
importance: Undecided → High
status: New → Confirmed
summary: - SubprocessUIFactory lacks several important methods
+ SubprocessUIFactory & QUIFactory lack several important methods
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

I don't think we have to implement get_non_echoed_password.

Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
milestone: none → 0.16
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.