Diff windows launched from qci are always in the background on x11 without compiz

[Lukáš Lalinský]

When I launch a diff window from qcommit, it's shown behind the commit window and it can't be moved to front. Maybe it's a Linux-specific problem, but I'm sure this used to work fine before.

[Alexander Belchenko (bialix)]

Lukáš Lalinský пишет:
> When I launch a diff window from qcommit, it's shown behind the commit
> window and it can't be moved to front. Maybe it's a Linux-specific
> problem, but I'm sure this used to work fine before.

Work OK on Windows.

Maybe you got this effect because commit window now based on QBzrDialog, while diff window still
based on QBzrWindow?

[Gary van der Merwe (garyvdm)]

I experienced this on a laptop I was borrowing. It was a Ubuntu jaunty machine. But it does not happen on my januty machine. Very weird.

Luks - do you still have this problem?

[Gary van der Merwe (garyvdm)]

I spent quite a bit of time debuging this, but made no progress. It seems to only happen with pyqt4.4, so if it bugs you, please upgrade pyqt .

[Gary van der Merwe (garyvdm)]

I upgraded the machine that I was having the problem with, and it did not fix it, so pyqt 4.4. is NOT the problem. :-(

[petsanikas (chrispetsos)]

I confirm this bug on Ubuntu Jaunty. These are my lib versions (copied from Bazzar Exporer's Help->About box)

Bazaar Explorer — Version Control for Human Beings
Version 0.9.0

QBzr 0.16.0, bzrlib 2.0.2, PyQt 4.4.4, Qt 4.5.0, Python 2.6.2

Quite annoying, because i am used to inspecting the diff while i am preparing to commit in order to write details about the commit in the "Message" area. With the "Commit" window always on top i have to move it in order to see the diff window which is rather annoying.
Indeed, the first comment has a point, the "Commit" window reminds me of always-on-top modal dialogs.

Would really like to see this fixed, i'm using bazaar explorer as a GUI front-end to my basic development machine, and this bug is the only thing that keeps me slow.

I am using qbzr as the Application Suite in bazaar explorer.
Keep up the good work guys and thanks in advance!

Chris.

[Gary van der Merwe (garyvdm)]

Yes - It is very irritating. It dose this on a laptop that I sometimes use.

I don't think it's related to any lib versions. This laptop had jaunty. I upgraded it to karmic, but it was still broken.

I don't have access to that laptop right now. Please could you create a new user account, and test if the same problem still exists to see if it is related to some config in $HOME.

[petsanikas (chrispetsos)]

Created new user account. Same problem for the new user. No change...

[petsanikas (chrispetsos)]

Just a quick tip to get the job done. If you open the diff window with the button at the main bazaar explorer window it opens correctly and doesn't always stay behind the commit window. The problems exists when you open the diff window with the button at the commit window.
So by clicking the "Diff" and "Commit" buttons at the main bazaar window, i can switch between them with Alt+Tab which is what i wanted...

[Gary van der Merwe (garyvdm)]

Good news - I just figured out how to reproduce this on my main dev machine: Switch off compviz. Hence - a work arround is to switch on compviz. This will also help me with finding a solution.

[petsanikas (chrispetsos)]

Well, it looks like i don't have a compiz-capable graphics card on my dev machine. When i go to System -> Preferences -> Appearance -> Visual Effects, i cannot set them to Normal or Extra (which is supposed to switch on compiz or not?). I always get the message "Desktop effects could not be enabled" which means i am stuck in a non-compiz environment...

[Alexander Belchenko (bialix)]

Also this bug appears on OSX, see https://bugs.launchpad.net/qbzr/+bug/500664

[Piotr Kalinowski (pitkali)]

I can still reproduce this bug on OSX 10.6, with bzr 2.1.0 and qbzr 0.18.1.

[Gary van der Merwe (garyvdm)]

I did some regression testing, and found that it it was caused by revision 814, where we changed the qcommit from a window to a dialog.

[Gary van der Merwe (garyvdm)]

I've fixed this in trunk. I would like to let this have some testing before we cherry pick to 0.14 and 0.18

[Piotr Kalinowski (pitkali)]

Now it works like a charm for me.

[Gary van der Merwe (garyvdm)]

On 24/02/2010 14:43, Piotr Kalinowski wrote:
> Now it works like a charm for me.

Cool. That covers Mac OSX. I would like to test it on windows.

[Piotr Kalinowski (pitkali)]

I have tested in on Windows and seems to work the same (and correctly, just to be clear) with 0.18.1 from bzr 2.1.0 installer and current qbzr trunk.

[Alexander Belchenko (bialix)]

Gary: trunk works OK on Windows. Your change added maximize button to window title though. I don't know is it critical though. I would like to backport this fix as is to 0.18 ASAP.

[Gordon Tyler (doxxx)]

On 2/26/2010 5:46 AM, Alexander Belchenko wrote:
> Gary: trunk works OK on Windows. Your change added maximize button to
> window title though. I don't know is it critical though. I would like to
> backport this fix as is to 0.18 ASAP.

I don't think a maximise button is such a bad thing. If the window is
resizable, then it makes sense to have a maximise button.