WindowsError(0, 'The operation completed successfully') trying to run editor

[Martin Pool]

Bazaar fails like so when trying to run a message editor on Windows.

By default you only get a short message, but for such a confusing thing we should either explicitly say "failed to run $program: $reason" or treat it as a crash. Probably the former.

[ 2728] 2009-08-27 14:53:57.413 INFO: Committing to: bzr+ssh://bazaar.launchpad.net/~daisyextension/daisyextension/main/
13.129 Selecting files for commit with filter []
[ 2728] 2009-08-27 14:53:57.852 INFO: modified test
14.611 check paths: None
14.671 aborting commit write group because of exception:
14.671 Traceback (most recent call last):
  File "bzrlib\commit.pyo", line 368, in commit
  File "bzrlib\builtins.pyo", line 3023, in get_message
  File "bzrlib\msgeditor.pyo", line 145, in edit_commit_message_encoded
  File "bzrlib\msgeditor.pyo", line 64, in _run_editor
  File "subprocess.pyo", line 444, in call
  File "subprocess.pyo", line 594, in __init__
  File "subprocess.pyo", line 822, in _execute_child
WindowsError: [Error 0] The operation completed successfully

[ 2728] 2009-08-27 14:53:58.954 INFO: aborting commit write group: WindowsError(0, 'The operation completed successfully')
15.081 Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 835, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1030, in run_bzr
  File "bzrlib\commands.pyo", line 647, in run_argv_aliases
  File "bzrlib\builtins.pyo", line 3043, in run
  File "bzrlib\decorators.pyo", line 192, in write_locked
  File "bzrlib\workingtree_4.pyo", line 197, in commit
  File "bzrlib\decorators.pyo", line 192, in write_locked
  File "bzrlib\mutabletree.pyo", line 228, in commit
  File "bzrlib\commit.pyo", line 368, in commit
  File "bzrlib\builtins.pyo", line 3023, in get_message
  File "bzrlib\msgeditor.pyo", line 145, in edit_commit_message_encoded
  File "bzrlib\msgeditor.pyo", line 64, in _run_editor
  File "subprocess.pyo", line 444, in call
  File "subprocess.pyo", line 594, in __init__
  File "subprocess.pyo", line 822, in _execute_child
WindowsError: [Error 0] The operation completed successfully

[Martin Pool (mbp)]

I asked in the question https://answers.edge.launchpad.net/bzr/+question/80945 what editor juliec was trying to run here.

On Windows we perhaps should ask using readline or something because running an editor in the terminal is unlikely to work by default?