duplicated input device entries in sound recorder

[Miguel Gaspar]

Steps to reproduce:
1- launch Sound Recorder (gnome-sound-recorder);
2- check the available input sources in "Record from Input" drop-down list;
3- start a recording, then stop the recording;
4- check the input list again: all items are repeated.

This behavior was observed in Sound Recorder 2.14.0, provided by gnome-media-2.14.0-0ubuntu1, in an Asus L3C. The sound hardware is Intel 82801CA/CAM AC'97 Audio Controller.

[Miguel Gaspar (ghaspias)]

I looked at the source for grecord, in gsr-window.c the callback for the record action calls fill_record_input():

static void
record_cb (GtkAction *action,
    GSRWindow *window)
{
 GSRWindowPrivate *priv = window->priv;

 if (priv->record) {
  shutdown_pipeline (priv->record);
  if (!make_record_source (window)) exit (1);
  fill_record_input (window);
 }

 if ((priv->record = make_record_pipeline (window))) {
  window->priv->len_secs = 0;
  window->priv->saved = FALSE;

  g_object_set (G_OBJECT (priv->record->sink),
         "location", priv->record_filename,
         NULL);

  gst_element_set_state (priv->record->pipeline, GST_STATE_PLAYING);
 }
}

But fill_record_input() appends to the combo-box:

static void
fill_record_input (GSRWindow *window)
{
 GstElement *e;
 const GList *l;
 int i = 0;

 g_return_if_fail (GST_IS_MIXER (window->priv->mixer));

 for (l = gst_mixer_list_tracks (window->priv->mixer); l != NULL; l = l->next) {
  GstMixerTrack *t = l->data;
  if (t->flags & GST_MIXER_TRACK_INPUT) {
   gtk_combo_box_append_text (GTK_COMBO_BOX (window->priv->input), t->label);
   ++i;
  }
  if (t->flags & GST_MIXER_TRACK_RECORD) {
   gtk_combo_box_set_active (GTK_COMBO_BOX (window->priv->input), i - 1);
  }
 }
}

I don't know why fill_record_input() is called in record_cb(), but either by removing that call or by changing fill_record_input(), this should be easy to correct.

[Miguel Gaspar (ghaspias)]

This is already filled in gnome bugzilla as bug #329922.

[Sebastien Bacher (seb128)]

Thank you for the work on that

[Andy Bovett (abovett)]

I'd like to add that not only do the sources get repeated, but if you change the selected source, it changes next back time you hit "Record".

There also seem to be other problems with recording via sound recorder (very quiet or no sound on some systems) but I guess they are separate bugs. Still, it would be nice if Dapper could ship with a basically working Sound Recorder - at the moment it seems to be broken to some extent on every system I've tried it on :(

Andy B

[Sebastien Bacher (seb128)]

Right, other issues are candidates for other bugs. That one has a dapper milestone, we will try to fix it for dapper. If the program doesn't work fine for you and you want to help sorting that before dapper feel free to open bugs about what doesn't work fine

[Baptiste Mille-Mathias (bmillemathias)]

For information, I push a patch on http://bugzilla.gnome.org/show_bug.cgi?id=329922. it seems to correct the bug but need to confirm with the maintainer.

[Baptiste Mille-Mathias (bmillemathias)]

I attach the fix here too.

[Sebastien Bacher (seb128)]

Fix uploaded to edgy:

 gnome-media (2.14.2-1ubuntu4) edgy; urgency=low
 .
   * debian/patches/07_duplicate_entries_for_combo.patch:
     - fix the grecord combo list duplicating entries on selection,
       thanks to Baptiste Mille-Mathias <email address hidden>
       for working on that (Ubuntu: #42022)

[Sebastien Bacher (seb128)]

Opening a dapper task, I'll backport the patch if we get no complain about it breaking something to edgy

[Florian Boucault (fboucault)]

It worked well for me during the last months.

[Florian Boucault (fboucault)]

Let's take care of it now :)