code review has no way to give a message for Rejected/etc statements

[John A Meinel]

somewhat related to bug #383352

When I go to update the status of a merge proposal I often have a reason I would like to convey at the same time. (rejected especially, but other state changes also often have a reason.)

Once you have marked an MP rejected, there doesn't seem to be a way to add a comment without requesting a *new* review.

I'm guessing the recommended flow is:
 1) Add a comment
 2) Mark it rejected

Though this generates 2 emails, when one would easily suffice. (I can certainly send an email of:
 this is bogus
 merge: rejected
)

However, if I mark something as rejected, and then want to go back and give the user a reason... I can't.

This would also be a good way for something like bug #419323. So that we have a time to say:
  I'm rejecting this proposal because it is superseded by this one

[Martin Pool (mbp)]

2009/8/27 John A Meinel <email address hidden>:
> However, if I mark something as rejected, and then want to go back and
> give the user a reason... I can't.

This is probably a separate bug, but I think that generally you
_should_ be able to comment on resolved mps, but you should see a
warning that you probably don't want to. Duplicate bugs get this
about right.

--
Martin <http://launchpad.net/~mbp/>

[Tim Penhey (thumper)]

On Thu, 27 Aug 2009 18:11:29 Martin Pool wrote:
> 2009/8/27 John A Meinel <email address hidden>:
> > However, if I mark something as rejected, and then want to go back and
> > give the user a reason... I can't.
>
> This is probably a separate bug, but I think that generally you
> _should_ be able to comment on resolved mps, but you should see a
> warning that you probably don't want to. Duplicate bugs get this
> about right.

I'm sure there is a bug about not being able to comment on resolved proposals.

[Paul Hummer (rockstar)]

+1 from me. I think giving some context to why the proposal changed would be good.

[Aaron Bentley (abentley)]

Perhaps we should link to a review that rejected the proposal.

[Aaron Bentley (abentley)]

We now permit comments on rejected proposals