State reason changes missed due to missing newline on stderr

Bug #418053 reported by Tim Waugh
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Confirmed
Low
Unassigned

Bug Description

State reason changes are missed due to incorrect line endings polluting stderr:

D [24/Aug/2009:10:38:47 +0100] [Job 45] prnt/hpijs/hpcups.cpp 681: hpcups: returning status 0 from mainSTATE: +media-empty-error

Tags: patch
Revision history for this message
Tim Waugh (twaugh) wrote :
Revision history for this message
Tim Waugh (twaugh) wrote :

Actually it's even worse than that. This comes from hpcups:

D [24/Aug/2009:11:01:57 +0100] [Job 47] prnt/hpijs/hpcups.cpp 350: STATE: +marker-supply-low-warning

Obviously we don't want the file/line number at the start of that.

Here's a patch that fixes both problems.

Revision history for this message
David Suffield (david-suffield) wrote :

Thanks, patch was applied to tip...

Ani Balakrishnan (anib)
Changed in hplip:
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

I have found another missing newlinein hpcups. Patch attached.

Changed in hplip:
status: Fix Committed → Confirmed
tags: added: patch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.