Conform heading and breadcrumb rules to UI 3.0
Bug #417089 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Barry Warsaw |
Bug Description
For IPrimaryContext, the default creation of a <h2> should not happen because it will not have breadcrumbs. The slot should honour the template if a heading is passed to it.
Related branches
lp:~barry/launchpad/417089-headings
Merged
into
lp:launchpad
- Guilherme Salgado (community): Approve
- Diff: None lines
Changed in launchpad-foundations: | |
assignee: | Curtis Hovey (sinzui) → Barry Warsaw (barry) |
Changed in launchpad-foundations: | |
status: | Triaged → In Progress |
description: | updated |
Changed in launchpad-foundations: | |
status: | In Progress → Fix Committed |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Michael had these thoughts: title</ h2>,
So the heading slot always defaults to displaying <h2>context.
with only the following two exceptions:
1. if the current context is an IPrimaryContext, then the whole slot+breadcrumb s will not display (as per sinzui's suggestion).
heading-
2. if the current context is not an IPrimaryContext but we are viewing context. title</ h1>
the index of the current context then it will default to an h1:
<h1>
If and only if you need an inline-editable widget do you need to fill edit_heading_ widget' so people are very aware when
the heading slot - and in fact, we could call it something more obvious
in this case 'inline_
filling it.