check reports "Missing inventory {('TREE_ROOT'..." for trivial non-rich-root branch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Invalid
|
Critical
|
Robert Collins | ||
2.0 |
Fix Released
|
Critical
|
Robert Collins |
Bug Description
With current bzr.dev:
andrew@
Created a standalone tree (format: 1.9)
andrew@
andrew@
Committing to: /tmp/non-rr-test/
Committed revision 1.
andrew@
Checking working tree at '/tmp/non-rr-test'.
Checking branch at 'file:/
Checking repository at 'file:/
checked repository <bzrlib.
1 revisions
0 file-ids
Missing inventory {('TREE_ROOT', '<email address hidden>')}
checked branch file://
"bzr check" on a trivial, new branch should not be finding problems! Rich-root formats, like 2a, seem to be unaffected. My guess is that this is a bug in check on non-rich-root repositories (rather than a bug in what is stored in the repository that check discovers). Upgrading to 2a fixes the problem.
(There have been other reports that look like this problem, e.g. <https:/
As this doesn't affect 2a branches (and is corrected by upgrading to 2a) I'm not targetting this to 2.0. But I'm still marking it as High as it seems pretty serious to me.
Related branches
- bzr-core: Pending requested
- Diff: 1359 lines (has conflicts)
- Martin Pool: Approve
- Vincent Ladeuil: Approve
- Andrew Bennetts: Approve
- Diff: 98 lines (has conflicts)
Changed in bzr: | |
importance: | High → Critical |
Changed in bzr: | |
assignee: | nobody → Robert Collins (lifeless) |
Changed in bzr: | |
status: | Confirmed → In Progress |
Changed in bzr: | |
status: | In Progress → Fix Committed |
Changed in bzr: | |
status: | Fix Committed → Fix Released |
Changed in bzr: | |
status: | Invalid → Fix Released |
status: | Fix Released → Invalid |
Respectfully, I think that this bug is Critical for releasing 2a as the default format. Check should not be spouting irrelevant errors in a properly-working upgrade process. A clean upgrade process is imperative for Bazaar's roll out of a new default format. As it is, rather than all check output being problems, some of the output is irrelevant and can safely be ignored (or so we think). Again, check is part of the upgrade process as described at http:// doc.bazaar- vcs.org/ bzr.dev- html/en/ upgrade- guide/index. html and check has broken its commitment that "The working tree and branch checks will only give output if a problem is detected." As such, the upgrade process is broken and I don't think that 2a should be made the default until the upgrade process is working *right*.
(See https:/ /lists. ubuntu. com/archives/ bazaar/ 2009q3/ 061248. html for another example of the same problem.)