SST donor logs an error (Invalid argument) even if SST was successful

[Alex Yurchenko]

Log message:
090819 16:08:57 [Note] [DEBUG] WSREP: wsrep_sst_mysqldump complete: 22 (Invalid argument)

Offending code:
    if (proc.error()) {
        sql_print_error ("WSREP: '%s' failed: %d (%s)",
                         proc.str, proc.error(), strerror(proc.error()));
        return -proc.error();
    }

    sql_print_information (
        "[DEBUG] WSREP: wsrep_sst_mysqldump complete: %d (%s)",
        errno, strerror(errno));

Apparently it reports a stray errno and it is moot.

[Alex Yurchenko (ayurchen)]

According to "The Open Group Base Specifications Issue 6 IEEE Std 1003.1, 2004 Edition":

"The value of errno should only be examined when it is indicated to be valid by a function's return value."

So using errno in the above code is wrong.