Can't easily tell if printer is local or not

Bug #41400 reported by Andrew Jorgensen
14
Affects Status Importance Assigned to Milestone
libgnomecups (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

gnome-cups-manager no longer gives any visual indication of if a printer is local or not. It used to show a server icon rather than a printer icon if the printer was remote. I don't know that the server icon was the best thing but there should be some indication.

Also, I don't want to bring back the <email address hidden> thing. That was way to cluttered. Perhaps the best thing would be an "emblem" ala nautilus icons.

Revision history for this message
Patrice Vetsel (vetsel-patrice) wrote :

Thank you for your report.

Revision history for this message
Andrew Jorgensen (ajorg) wrote :

I disagree with the change to "Wishlist". This is a bug, possibly in the icon theme. The UI already differentiates between local and remote print queues but the icon themes use the same icon for both, or something.

In fact, when the window first appears you will see the older icons and they will be replaced by newer icons which then don't change when the theme changes. I don't know what's going on with that, but it's probably not right either.

Revision history for this message
Martin Pitt (pitti) wrote :

Work theory so far:

gnome_cups_printer_get_is_local (GnomeCupsPrinter *printer)
{
  g_return_val_if_fail (GNOME_CUPS_IS_PRINTER (printer), FALSE);
  return (printer->details->device_uri != NULL) &&
   (strcmp (printer->details->device_uri, "") != 0);
}

is wrong, since device_uri will be nonempty also for network printers. Changing that to test for http://, ipp://, and smb:// URLs should fix it.

Changed in gnome-cups-manager:
status: Unconfirmed → In Progress
assignee: nobody → ubuntu-printing
Revision history for this message
Martin Pitt (pitti) wrote :

Turned out to be trivial to fix, marking for dapper.

Changed in libgnomecups:
assignee: ubuntu-printing → pitti
Revision history for this message
Martin Pitt (pitti) wrote :

 libgnomecups (0.2.2-1ubuntu4) dapper; urgency=low
 .
   * libgnomecups/gnome-cups-printer.c, gnome_cups_printer_get_is_local():
     - Fix detection of local printers: Remote printers do not have an empty
       device URI, but one starting with http://, ipp://, or smb://.
     - Closes: LP#41400

Changed in libgnomecups:
status: In Progress → Fix Released
Revision history for this message
Andrew Jorgensen (ajorg) wrote :

I'm not sure what isn't quite right about it yet but all my printers are remote and now only two of them show as remote. This is an improvent, but not a complete improvement.

Oh, interesting: the device uri for those two printers says ///dev/null but they work fine. I wonder if there is a better way to determine localness of a printer. How was it done in breezy?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.