qbzr needs repository.iter_branches method instead of find_branches
Bug #413970 reported by
Alexander Belchenko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Fix Released
|
Low
|
Jelmer Vernooij | ||
QBzr |
Confirmed
|
Low
|
Unassigned |
Bug Description
See https:/
Gary started this change in branch https:/
Dear core bzr.devs, can you say which tests new method needs to get it merged to bzr.dev?
Related branches
lp:~jelmer/brz/iter-branch
- Martin Packman: Approve
-
Diff: 103 lines (+15/-10)5 files modifiedbreezy/check.py (+1/-1)
breezy/repository.py (+7/-5)
breezy/tests/per_repository/test_repository.py (+3/-3)
breezy/upgrade.py (+1/-1)
doc/en/release-notes/brz-3.1.txt (+3/-0)
Changed in qbzr: | |
importance: | Undecided → Low |
status: | New → Confirmed |
tags: | added: api find-branches |
Changed in bzr: | |
assignee: | canonical-bazaar (canonical-bazaar) → nobody |
tags: | added: check-for-breezy |
Changed in brz: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Jelmer Vernooij (jelmer) |
tags: | removed: check-for-breezy |
Changed in brz: | |
milestone: | none → 3.1.0 |
Changed in brz: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Gary's change http:// bazaar. launchpad. net/~garyvdm/ bzr/find_ branches_ generator/ revision/ 4604 seems to be changing the existing method to be an iterator rather than to return a list. That's strictly speaking an API break and should be at least mentioned in NEWS. I would probably let it merge though. I don't think there would be many existing callers that really need a list and it's easy enough to cast it if you do.
Therefore we'd just need to check there are already tests for this - probably in per_repository.