Refresh main view after adding, and committing changes.

[Craig Hewetson]

Have changes.
Commit changes.
Note, one now has to manually refresh.

Recommend that it refreshes automatically.

I guess the problem is that bzr-explorer doesn't know when to refresh. Need to hook into qbzr dialog's to know when an operation has successfully completed.

[Gary van der Merwe (garyvdm)]

If we fix Bug 347990, then bzr-explorer will be able to tell if it need to refresh.

[Alexander Belchenko (bialix)]

I think the problem is much deeper. You need to auto refresh as well after pull, merge, switch, bind/unbind, uncommit, revert, add. Am I forgot something?

Currently dialogs from qbzr/bzr-gtk invoked as separate processes, so we have to implement some IPC messaging here. On Windows Events could be used (similar to the code I wrote for supporting Ctrl+C signal in qsubprocess). I don't know qhat should be used on Linux.

[Ian Clatworthy (ian-clatworthy)]

IPC with the qbzr (or bzr-gtk) applets is one option. Another is to try setting up some sort of file-system watcher on selected files, e.g. dirstate after 'Add' or 'Commit'.

Automatic refreshing is really important IMO for a great user experience! My initial priority though is getting functional coverage of tasks completed so that users can remain in Explorer 95-99% of the time without needing to go to the command line. As a consequence, I'm not optimistic that I'll have time to fix this prior to 1.0 shipping around the end of August. I'll take patches though. :-)

[Alexander Belchenko (bialix)]

Ian Clatworthy пишет:
> IPC with the qbzr (or bzr-gtk) applets is one option. Another is to try
> setting up some sort of file-system watcher on selected files, e.g.
> dirstate after 'Add' or 'Commit'.

Hmm, Lukas has used some DirectoryWatcher service from PyQt when he
wrote our qmain application. Perhaps we need to inspect that code more
closely and decide if we can reuse it for bzr-explorer.

[Alexander Belchenko (bialix)]

Alexander Belchenko пишет:
> Ian Clatworthy пишет:
>> IPC with the qbzr (or bzr-gtk) applets is one option. Another is to try
>> setting up some sort of file-system watcher on selected files, e.g.
>> dirstate after 'Add' or 'Commit'.
>
> Hmm, Lukas has used some DirectoryWatcher service from PyQt when he
> wrote our qmain application. Perhaps we need to inspect that code more
> closely and decide if we can reuse it for bzr-explorer.
>

QFileSystemWatcher class from QtCore.

[Craig Hewetson (craighewetson-deactivatedaccount)]

Does the filesystem watcher need to run "bzr status"? If not then how does it pick up the difference between unversioned and newly versioned files? Or changes to already added files?

If it needs to run "bzr status" how often do we want this to happen? (performance)

[Gary van der Merwe (garyvdm)]

On Thu, Aug 13, 2009 at 12:07 PM, Craig Hewetson<email address hidden> wrote:
> Does the filesystem watcher need to run "bzr status"? If not then how
> does it pick up the difference between unversioned and newly versioned
> files? Or changes to already added files?
>
> If it needs to run "bzr status" how often do we want this to happen?
> (performance)

I would think that it would need to refresh (which would include
running status) if:
  * A file's contents has changed (The last modified changed)
  Or
  * The working tree (or branch?) parent_id's change.
and
* The window has focus.

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> On Thu, Aug 13, 2009 at 12:07 PM, Craig Hewetson<email address hidden> wrote:
>> Does the filesystem watcher need to run "bzr status"? If not then how
>> does it pick up the difference between unversioned and newly versioned
>> files? Or changes to already added files?
>>
>> If it needs to run "bzr status" how often do we want this to happen?
>> (performance)
>
>
> I would think that it would need to refresh (which would include
> running status) if:
> * A file's contents has changed (The last modified changed)
> Or
> * The working tree (or branch?) parent_id's change.
> and
> * The window has focus.
>

After looking at the qbzr/lib/statuscache.py I'm not sure filesystem
watcher is best idea. Maybe IPC messages will work better here in the end.

[Alexander Belchenko (bialix)]

I've fixed Bug #347990. HTH

[Ian Clatworthy (ian-clatworthy)]

This turned out to be pretty easy to do in the end. The trick was to switch to using Qt's process management instead of Python's vanilla subprocess module.

[Craig Hewetson (craighewetson-deactivatedaccount)]

I've tested it and it works well.

Thanks!!