Crash (internal error) when removing font from empty list in SVG font editor

[mvandeg]

When right clicking on an empty Font list in the SVG Font Editor, the user gets the menu option Remove. If this option is clicked, Inkscape reports that an internal error has occured and it closes. The Inkscape version is (copied from the about dialog): Inkscape 0.46+devel 22040, built Aug 10 2009 on Windows XP.

[Alvin Penner (apenner)]

confirmed on Windows XP, build 0.47pre1, backtrace follows:

(gdb) run
Starting program: C:\Program Files\Inkscape/inkscape.exe
[New thread 3268.0xc3c]

Program received signal SIGSEGV, Segmentation fault.
0x0086fa8a in Inkscape::UI::Dialog::SvgFontsDialog::remove_selected_font ()
(gdb) bt
#0 0x0086fa8a in Inkscape::UI::Dialog::SvgFontsDialog::remove_selected_font ()
Cannot access memory at address 0x22f4a0
(gdb) c
Continuing.
error return win32-nat.c:1254 was 31

[su_v (suv-lp)]

Confirmed on OS X 10.5.8 with Inkscape 0.46+devel r22028

[Alisher Niyazov (zman69)]

confirmed on 0.47 too

here is the fix:

file: /src/ui/dialog/svg-fonts-dialog.cpp (revision 9676)

after the line:
604 SPFont* font = get_selected_spfont();

insert new line:
if (!font) return;

(I have no access to change the source)

[su_v (suv-lp)]

Crash and fix confirmed with Inkscape 0.48+devel r9673 on OS X 10.5.8

Thank you for looking into this - attaching the proposed change as patch.

[ScislaC (scislac)]

Thank you Alisher Niyazov! Tested, confirmed fix, committed. If you submit another fix (prefererably in patch form) you will be granted commit access if you're interested.

[ScislaC (scislac)]

assigned to Alisher as that's who provided the fix