wrong path usage in check_perms_grsecurity.py
Bug #411192 reported by
Hanno Böck
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| GNU Mailman |
Fix Released
|
Undecided
|
Mark Sapiro | ||
Bug Description
check_perms_
uses prefix at two points where it should use var_prefix. See attached patch.
Revision history for this message
| Hanno Böck (hanno-hboeck) wrote | #1 |
Revision history for this message
| Mark Sapiro (msapiro) wrote | #2 |
| Changed in mailman: | |
| assignee: | nobody → Mark Sapiro (msapiro) |
| status: | New → In Progress |
Revision history for this message
| Hanno Böck (hanno-hboeck) wrote | #3 |
| Changed in mailman: | |
| status: | In Progress → Fix Committed |
| Changed in mailman: | |
| milestone: | none → 2.1.13rc1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I hate to patch 'contrib' modules that I don't use as I don't know whether the resultant module does what it's supposed to, and it's really the responsibility of the contributor.
However, that said, the flaw you point out is obvious enough that I will do it in this case. Note however the following deficiencies in your patch:
1) The paths module has no var_prefix attribute. This needs to be mm_cfg.VAR_PREFIX.
2) You missed line 90
file = paths.prefix + '/data/
needs to be changed also.